* Patch "hwrng: core - correct error check of kthread_run call" has been added to the 4.1-stable tree
@ 2015-08-14 0:44 gregkh
0 siblings, 0 replies; only message in thread
From: gregkh @ 2015-08-14 0:44 UTC (permalink / raw)
To: schwidefsky, gregkh, herbert; +Cc: stable, stable-commits
This is a note to let you know that I've just added the patch titled
hwrng: core - correct error check of kthread_run call
to the 4.1-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
hwrng-core-correct-error-check-of-kthread_run-call.patch
and it can be found in the queue-4.1 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@vger.kernel.org> know about it.
>From 17fb874dee093139923af8ed36061faa92cc8e79 Mon Sep 17 00:00:00 2001
From: Martin Schwidefsky <schwidefsky@de.ibm.com>
Date: Fri, 24 Jul 2015 13:13:30 +0200
Subject: hwrng: core - correct error check of kthread_run call
From: Martin Schwidefsky <schwidefsky@de.ibm.com>
commit 17fb874dee093139923af8ed36061faa92cc8e79 upstream.
The kthread_run() function can return two different error values
but the hwrng core only checks for -ENOMEM. If the other error
value -EINTR is returned it is assigned to hwrng_fill and later
used on a kthread_stop() call which naturally crashes.
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
drivers/char/hw_random/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/char/hw_random/core.c
+++ b/drivers/char/hw_random/core.c
@@ -429,7 +429,7 @@ static int hwrng_fillfn(void *unused)
static void start_khwrngd(void)
{
hwrng_fill = kthread_run(hwrng_fillfn, NULL, "hwrng");
- if (hwrng_fill == ERR_PTR(-ENOMEM)) {
+ if (IS_ERR(hwrng_fill)) {
pr_err("hwrng_fill thread creation failed");
hwrng_fill = NULL;
}
Patches currently in stable-queue which might be from schwidefsky@de.ibm.com are
queue-4.1/hwrng-core-correct-error-check-of-kthread_run-call.patch
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2015-08-14 0:44 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-08-14 0:44 Patch "hwrng: core - correct error check of kthread_run call" has been added to the 4.1-stable tree gregkh
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).