stable.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Patch "HID: uclogic: fix limit in uclogic_tablet_enable()" has been added to the 4.1-stable tree
@ 2015-08-19 16:20 gregkh
  0 siblings, 0 replies; only message in thread
From: gregkh @ 2015-08-19 16:20 UTC (permalink / raw)
  To: dan.carpenter, gregkh, jkosina, spbnick; +Cc: stable, stable-commits


This is a note to let you know that I've just added the patch titled

    HID: uclogic: fix limit in uclogic_tablet_enable()

to the 4.1-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     hid-uclogic-fix-limit-in-uclogic_tablet_enable.patch
and it can be found in the queue-4.1 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@vger.kernel.org> know about it.


>From 4a8e70f5d0d80675fc17b9ba1e62db8ca6b91775 Mon Sep 17 00:00:00 2001
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Wed, 29 Jul 2015 13:16:06 +0300
Subject: HID: uclogic: fix limit in uclogic_tablet_enable()

From: Dan Carpenter <dan.carpenter@oracle.com>

commit 4a8e70f5d0d80675fc17b9ba1e62db8ca6b91775 upstream.

The limit should be ARRAY_SIZE(params) (5 elements) here instead of
sizeof(params) (20 bytes).

Fixes: 08177f40bd00 ('HID: uclogic: merge hid-huion driver in hid-uclogic')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Nikolai Kondrashov <spbnick@gmail.com>
Signed-off-by: Jiri Kosina <jkosina@suse.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

---
 drivers/hid/hid-uclogic.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/hid/hid-uclogic.c
+++ b/drivers/hid/hid-uclogic.c
@@ -858,7 +858,7 @@ static int uclogic_tablet_enable(struct
 	for (p = drvdata->rdesc;
 	     p <= drvdata->rdesc + drvdata->rsize - 4;) {
 		if (p[0] == 0xFE && p[1] == 0xED && p[2] == 0x1D &&
-		    p[3] < sizeof(params)) {
+		    p[3] < ARRAY_SIZE(params)) {
 			v = params[p[3]];
 			put_unaligned(cpu_to_le32(v), (s32 *)p);
 			p += 4;


Patches currently in stable-queue which might be from dan.carpenter@oracle.com are

queue-4.1/hid-uclogic-fix-limit-in-uclogic_tablet_enable.patch

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2015-08-19 16:20 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-08-19 16:20 Patch "HID: uclogic: fix limit in uclogic_tablet_enable()" has been added to the 4.1-stable tree gregkh

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).