stable.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Patch "clk: versatile: off by one in clk_sp810_timerclken_of_get()" has been added to the 3.10-stable tree
@ 2015-09-16 18:12 gregkh
  0 siblings, 0 replies; only message in thread
From: gregkh @ 2015-09-16 18:12 UTC (permalink / raw)
  To: dan.carpenter, gregkh, pawel.moll, sboyd; +Cc: stable, stable-commits


This is a note to let you know that I've just added the patch titled

    clk: versatile: off by one in clk_sp810_timerclken_of_get()

to the 3.10-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     clk-versatile-off-by-one-in-clk_sp810_timerclken_of_get.patch
and it can be found in the queue-3.10 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@vger.kernel.org> know about it.


>From 3294bee87091be5f179474f6c39d1d87769635e2 Mon Sep 17 00:00:00 2001
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Wed, 29 Jul 2015 13:17:06 +0300
Subject: clk: versatile: off by one in clk_sp810_timerclken_of_get()

From: Dan Carpenter <dan.carpenter@oracle.com>

commit 3294bee87091be5f179474f6c39d1d87769635e2 upstream.

The ">" should be ">=" or we end up reading beyond the end of the array.

Fixes: 6e973d2c4385 ('clk: vexpress: Add separate SP810 driver')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Pawel Moll <pawel.moll@arm.com>
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

---
 drivers/clk/versatile/clk-sp810.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

--- a/drivers/clk/versatile/clk-sp810.c
+++ b/drivers/clk/versatile/clk-sp810.c
@@ -128,8 +128,8 @@ struct clk *clk_sp810_timerclken_of_get(
 {
 	struct clk_sp810 *sp810 = data;
 
-	if (WARN_ON(clkspec->args_count != 1 || clkspec->args[0] >
-			ARRAY_SIZE(sp810->timerclken)))
+	if (WARN_ON(clkspec->args_count != 1 ||
+		    clkspec->args[0] >=	ARRAY_SIZE(sp810->timerclken)))
 		return NULL;
 
 	return sp810->timerclken[clkspec->args[0]].clk;


Patches currently in stable-queue which might be from dan.carpenter@oracle.com are

queue-3.10/clk-versatile-off-by-one-in-clk_sp810_timerclken_of_get.patch

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2015-09-16 20:00 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-16 18:12 Patch "clk: versatile: off by one in clk_sp810_timerclken_of_get()" has been added to the 3.10-stable tree gregkh

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).