From: Ben Hutchings <ben@decadent.org.uk>
To: Mike Marciniszyn <mike.marciniszyn@intel.com>, stable@vger.kernel.org
Cc: linux-rdma@vger.kernel.org
Subject: Re: [PATCH 3.2] IB/qib: Change lkey table allocation to support more MRs
Date: Thu, 08 Oct 2015 13:49:54 +0100 [thread overview]
Message-ID: <1444308594.2956.255.camel@decadent.org.uk> (raw)
In-Reply-To: <20150929145143.27497.86046.stgit@phlsvslse11.ph.intel.com>
[-- Attachment #1: Type: text/plain, Size: 978 bytes --]
On Tue, 2015-09-29 at 10:51 -0400, Mike Marciniszyn wrote:
> The lkey table is allocated with with a get_user_pages() with an
> order based on a number of index bits from a module parameter.
>
> The underlying kernel code cannot allocate that many contiguous
> pages.
>
> There is no reason the underlying memory needs to be physically
> contiguous.
>
> This patch:
> - switches the allocation/deallocation to vmalloc/vfree
> - caps the number of bits to 23 to insure at least 1 generation bit
> o this matches the module parameter description
>
> Cc: stable@vger.kernel.org # 3.2
> Reviewed-by: Vinit Agnihotri <vinit.abhay.agnihotri@intel.com>
> Signed-off-by: Mike Marciniszyn <mike.marciniszyn@intel.com>
> Signed-off-by: Doug Ledford <dledford@redhat.com>
[...]
qib_dev_warn() is not defined. But, I worked out how to backport this
anyway.
Ben.
--
Ben Hutchings
Once a job is fouled up, anything done to improve it makes it worse.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 811 bytes --]
prev parent reply other threads:[~2015-10-08 12:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-29 14:51 [PATCH 3.2] IB/qib: Change lkey table allocation to support more MRs Mike Marciniszyn
2015-09-30 7:46 ` Haggai Eran
2015-10-02 13:10 ` Marciniszyn, Mike
2015-10-06 5:58 ` Haggai Eran
2015-10-08 12:49 ` Ben Hutchings [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1444308594.2956.255.camel@decadent.org.uk \
--to=ben@decadent.org.uk \
--cc=linux-rdma@vger.kernel.org \
--cc=mike.marciniszyn@intel.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).