From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:38856 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753100AbbJMUp1 (ORCPT ); Tue, 13 Oct 2015 16:45:27 -0400 Subject: Patch "perf hists: Update the column width for the "srcline" sort key" has been added to the 4.1-stable tree To: acme@redhat.com, andi@firstfloor.org, gregkh@linuxfoundation.org, jolsa@kernel.org, namhyung@kernel.org Cc: , From: Date: Tue, 13 Oct 2015 13:38:57 -0700 Message-ID: <1444768737161177@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org List-ID: This is a note to let you know that I've just added the patch titled perf hists: Update the column width for the "srcline" sort key to the 4.1-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: perf-hists-update-the-column-width-for-the-srcline-sort-key.patch and it can be found in the queue-4.1 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let know about it. >>From e8e6d37e73e6b950c891c780745460b87f4755b6 Mon Sep 17 00:00:00 2001 From: Arnaldo Carvalho de Melo Date: Mon, 10 Aug 2015 16:53:54 -0300 Subject: perf hists: Update the column width for the "srcline" sort key From: Arnaldo Carvalho de Melo commit e8e6d37e73e6b950c891c780745460b87f4755b6 upstream. When we introduce a new sort key, we need to update the hists__calc_col_len() function accordingly, otherwise the width will be limited to strlen(header). We can't update it when obtaining a line value for a column (for instance, in sort__srcline_cmp()), because we reset it all when doing a resort (see hists__output_recalc_col_len()), so we need to, from what is in the hist_entry fields, set each of the column widths. Cc: Namhyung Kim Cc: Andi Kleen Cc: Jiri Olsa Fixes: 409a8be61560 ("perf tools: Add sort by src line/number") Link: http://lkml.kernel.org/n/tip-jgbe0yx8v1gs89cslr93pvz2@git.kernel.org Signed-off-by: Arnaldo Carvalho de Melo Signed-off-by: Greg Kroah-Hartman --- tools/perf/util/hist.c | 3 +++ 1 file changed, 3 insertions(+) --- a/tools/perf/util/hist.c +++ b/tools/perf/util/hist.c @@ -151,6 +151,9 @@ void hists__calc_col_len(struct hists *h hists__new_col_len(hists, HISTC_LOCAL_WEIGHT, 12); hists__new_col_len(hists, HISTC_GLOBAL_WEIGHT, 12); + if (h->srcline) + hists__new_col_len(hists, HISTC_SRCLINE, strlen(h->srcline)); + if (h->transaction) hists__new_col_len(hists, HISTC_TRANSACTION, hist_entry__transaction_len()); Patches currently in stable-queue which might be from acme@redhat.com are queue-4.1/perf-tools-add-empty-build-files-for-architectures-lacking-them.patch queue-4.1/perf-stat-get-correct-cpu-id-for-print_aggr.patch queue-4.1/perf-tools-fix-copying-of-proc-kcore.patch queue-4.1/perf-hists-update-the-column-width-for-the-srcline-sort-key.patch queue-4.1/perf-header-fixup-reading-of-header_nrcpus-feature.patch