From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:38300 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751197AbbJQThc (ORCPT ); Sat, 17 Oct 2015 15:37:32 -0400 Subject: Patch "ALSA: hda - Disable power_save_node for IDT 92HD73xx chips" has been added to the 4.2-stable tree To: tiwai@suse.de, gregkh@linuxfoundation.org Cc: , From: Date: Sat, 17 Oct 2015 12:37:30 -0700 Message-ID: <14451106502089@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org List-ID: This is a note to let you know that I've just added the patch titled ALSA: hda - Disable power_save_node for IDT 92HD73xx chips to the 4.2-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: alsa-hda-disable-power_save_node-for-idt-92hd73xx-chips.patch and it can be found in the queue-4.2 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let know about it. >>From c7e1008048a97148d3aecae742f66fb2f944644c Mon Sep 17 00:00:00 2001 From: Takashi Iwai Date: Sun, 4 Oct 2015 22:44:12 +0200 Subject: ALSA: hda - Disable power_save_node for IDT 92HD73xx chips From: Takashi Iwai commit c7e1008048a97148d3aecae742f66fb2f944644c upstream. The recent widget power saving introduced some unavoidable click noises on old IDT 92HD73xx chips while it still seems working on the compatible new chips. In the bugzilla, we tried lots of tests and workarounds, but they didn't help much. So, let's disable the feature for these specific chips as the least (but safest) fix. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=104981 Signed-off-by: Takashi Iwai Signed-off-by: Greg Kroah-Hartman --- sound/pci/hda/patch_sigmatel.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) --- a/sound/pci/hda/patch_sigmatel.c +++ b/sound/pci/hda/patch_sigmatel.c @@ -4520,7 +4520,11 @@ static int patch_stac92hd73xx(struct hda return err; spec = codec->spec; - codec->power_save_node = 1; + /* enable power_save_node only for new 92HD89xx chips, as it causes + * click noises on old 92HD73xx chips. + */ + if ((codec->core.vendor_id & 0xfffffff0) != 0x111d7670) + codec->power_save_node = 1; spec->linear_tone_beep = 0; spec->gen.mixer_nid = 0x1d; spec->have_spdif_mux = 1; Patches currently in stable-queue which might be from tiwai@suse.de are queue-4.2/alsa-hda-disable-power_save_node-for-idt-92hd73xx-chips.patch queue-4.2/x86-kexec-fix-kexec-crash-in-syscall-kexec_file_load.patch queue-4.2/alsa-hda-disable-power_save_node-for-thinkpads.patch queue-4.2/alsa-hda-add-dock-support-for-thinkpad-t550.patch queue-4.2/alsa-hda-apply-spdif-pin-ctl-to-macbookpro-12-1.patch queue-4.2/leds-lp55xx-correct-kconfig-dependency-for-f-w-user-helper.patch queue-4.2/alsa-synth-fix-conflicting-oss-device-registration-on-awe32.patch queue-4.2/alsa-hda-tegra-async-probe-for-avoiding-module-loading-deadlock.patch