* Patch "mfd: max77843: Fix max77843_chg_init() return on error" has been added to the 4.1-stable tree
@ 2015-10-23 14:32 gregkh
0 siblings, 0 replies; only message in thread
From: gregkh @ 2015-10-23 14:32 UTC (permalink / raw)
To: javier, gregkh, k.kozlowski, lee.jones; +Cc: stable, stable-commits
This is a note to let you know that I've just added the patch titled
mfd: max77843: Fix max77843_chg_init() return on error
to the 4.1-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
mfd-max77843-fix-max77843_chg_init-return-on-error.patch
and it can be found in the queue-4.1 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@vger.kernel.org> know about it.
>From 1b52e50f2a402a266f1ba2281f0a57e87637a047 Mon Sep 17 00:00:00 2001
From: Javier Martinez Canillas <javier@osg.samsung.com>
Date: Mon, 21 Sep 2015 14:26:54 +0200
Subject: mfd: max77843: Fix max77843_chg_init() return on error
From: Javier Martinez Canillas <javier@osg.samsung.com>
commit 1b52e50f2a402a266f1ba2281f0a57e87637a047 upstream.
If i2c_new_dummy() fails in max77843_chg_init(), an PTR_ERR(NULL) is
returned which is 0. So the function was wrongly returning a success
value instead of an error code.
Fixes: c7f585fe46d8 ("mfd: max77843: Add max77843 MFD driver core driver")
Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
drivers/mfd/max77843.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/mfd/max77843.c
+++ b/drivers/mfd/max77843.c
@@ -79,7 +79,7 @@ static int max77843_chg_init(struct max7
if (!max77843->i2c_chg) {
dev_err(&max77843->i2c->dev,
"Cannot allocate I2C device for Charger\n");
- return PTR_ERR(max77843->i2c_chg);
+ return -ENODEV;
}
i2c_set_clientdata(max77843->i2c_chg, max77843);
Patches currently in stable-queue which might be from javier@osg.samsung.com are
queue-4.1/mfd-max77843-fix-max77843_chg_init-return-on-error.patch
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2015-10-23 14:32 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-23 14:32 Patch "mfd: max77843: Fix max77843_chg_init() return on error" has been added to the 4.1-stable tree gregkh
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).