From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Mark Brown <broonie@kernel.org>
Cc: stable@vger.kernel.org, linux-spi@vger.kernel.org
Subject: Re: Applied "spi: dw: explicitly free IRQ handler in dw_spi_remove_host()" to the spi tree
Date: Fri, 23 Oct 2015 19:25:33 +0300 [thread overview]
Message-ID: <1445617533.22669.64.camel@linux.intel.com> (raw)
In-Reply-To: <20151023161810.GH29919@sirena.org.uk>
On Sat, 2015-10-24 at 01:18 +0900, Mark Brown wrote:
> On Fri, Oct 23, 2015 at 10:40:58AM +0300, Andy Shevchenko wrote:
> > On Fri, 2015-10-23 at 08:11 +0900, Mark Brown wrote:
> > > The patch
>
> > > spi: dw: explicitly free IRQ handler in dw_spi_remove_host()
>
> > This one seems incomplete.
>
> > Yes, we already have a fix 02f20387e1bc in your tree.
>
> This *appears* to be the same commit you are following up on (please
> always include human readable descriptions)
This commit (9f89566) is a redundancy made by mistake.
>
> > This makes free_irq() call duplicate.
Currently in your for-next branch
void dw_spi_remove_host(struct dw_spi *dws)
{
dw_spi_debugfs_remove(dws);
free_irq(dws->irq, dws->master);
^^^ (1)
if (dws->dma_ops && dws->dma_ops->dma_exit)
dws->dma_ops->dma_exit(dws);
spi_shutdown_chip(dws);
free_irq(dws->irq, dws->master);
^^^ (2)
}
EXPORT_SYMBOL_GPL(dw_spi_remove_host);
> > Please, remove it from your tree
> > or do the revert.
>
> Are you saying that you have realised that your patch is broken since
> sending it? I've dropped this commit...
No, the commit 02f20387e1bc is rightful and should be present in the
tree.
P.S. Commit IDs as they appear in your for-next branch of SPI tree.
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
next prev parent reply other threads:[~2015-10-23 16:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-22 23:11 Applied "spi: dw: explicitly free IRQ handler in dw_spi_remove_host()" to the spi tree Mark Brown
2015-10-23 7:40 ` Andy Shevchenko
2015-10-23 16:18 ` Mark Brown
2015-10-23 16:25 ` Andy Shevchenko [this message]
2015-10-23 16:30 ` Shevchenko, Andriy
-- strict thread matches above, loose matches on Subject: below --
2015-10-20 9:11 [PATCH v3 1/2] spi: dw: explicitly free IRQ handler in dw_spi_remove_host() Andy Shevchenko
2015-10-20 19:32 ` Applied "spi: dw: explicitly free IRQ handler in dw_spi_remove_host()" to the spi tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1445617533.22669.64.camel@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=broonie@kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).