* Patch "iwlwifi: dvm: fix D3 firmware PN programming" has been added to the 4.1-stable tree
@ 2015-11-06 0:14 gregkh
0 siblings, 0 replies; only message in thread
From: gregkh @ 2015-11-06 0:14 UTC (permalink / raw)
To: johannes.berg, gregkh, luciano.coelho; +Cc: stable, stable-commits
This is a note to let you know that I've just added the patch titled
iwlwifi: dvm: fix D3 firmware PN programming
to the 4.1-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
iwlwifi-dvm-fix-d3-firmware-pn-programming.patch
and it can be found in the queue-4.1 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@vger.kernel.org> know about it.
>From 5bd166872d8f99f156fac191299d24f828bb2348 Mon Sep 17 00:00:00 2001
From: Johannes Berg <johannes.berg@intel.com>
Date: Tue, 15 Sep 2015 14:36:09 +0200
Subject: iwlwifi: dvm: fix D3 firmware PN programming
From: Johannes Berg <johannes.berg@intel.com>
commit 5bd166872d8f99f156fac191299d24f828bb2348 upstream.
The code to send the RX PN data (for each TID) to the firmware
has a devastating bug: it overwrites the data for TID 0 with
all the TID data, leaving the remaining TIDs zeroed. This will
allow replays to actually be accepted by the firmware, which
could allow waking up the system.
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
drivers/net/wireless/iwlwifi/dvm/lib.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/net/wireless/iwlwifi/dvm/lib.c
+++ b/drivers/net/wireless/iwlwifi/dvm/lib.c
@@ -1022,7 +1022,7 @@ static void iwlagn_wowlan_program_keys(s
u8 *pn = seq.ccmp.pn;
ieee80211_get_key_rx_seq(key, i, &seq);
- aes_sc->pn = cpu_to_le64(
+ aes_sc[i].pn = cpu_to_le64(
(u64)pn[5] |
((u64)pn[4] << 8) |
((u64)pn[3] << 16) |
Patches currently in stable-queue which might be from johannes.berg@intel.com are
queue-4.1/iwlwifi-dvm-fix-d3-firmware-pn-programming.patch
queue-4.1/iwlwifi-fix-firmware-filename-for-3160.patch
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2015-11-06 0:14 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-11-06 0:14 Patch "iwlwifi: dvm: fix D3 firmware PN programming" has been added to the 4.1-stable tree gregkh
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).