stable.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Patch "ovl: fix open in stacked overlay" has been added to the 4.2-stable tree
@ 2015-11-06  6:38 gregkh
  0 siblings, 0 replies; only message in thread
From: gregkh @ 2015-11-06  6:38 UTC (permalink / raw)
  To: miklos, alban.crequy, dhowells, gregkh; +Cc: stable, stable-commits


This is a note to let you know that I've just added the patch titled

    ovl: fix open in stacked overlay

to the 4.2-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     ovl-fix-open-in-stacked-overlay.patch
and it can be found in the queue-4.2 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@vger.kernel.org> know about it.


>From 1c8a47df36d72ace8cf78eb6c228aa0f8027d3c2 Mon Sep 17 00:00:00 2001
From: Miklos Szeredi <miklos@szeredi.hu>
Date: Mon, 12 Oct 2015 15:56:20 +0200
Subject: ovl: fix open in stacked overlay

From: Miklos Szeredi <miklos@szeredi.hu>

commit 1c8a47df36d72ace8cf78eb6c228aa0f8027d3c2 upstream.

If two overlayfs filesystems are stacked on top of each other, then we need
recursion in ovl_d_select_inode().

I guess d_backing_inode() is supposed to do that.  But currently it doesn't
and that functionality is open coded in vfs_open().  This is now copied
into ovl_d_select_inode() to fix this regression.

Reported-by: Alban Crequy <alban.crequy@gmail.com>
Signed-off-by: Miklos Szeredi <miklos@szeredi.hu>
Fixes: 4bacc9c9234c ("overlayfs: Make f_path always point to the overlay...")
Cc: David Howells <dhowells@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

---
 fs/overlayfs/inode.c |    3 +++
 1 file changed, 3 insertions(+)

--- a/fs/overlayfs/inode.c
+++ b/fs/overlayfs/inode.c
@@ -363,6 +363,9 @@ struct inode *ovl_d_select_inode(struct
 		ovl_path_upper(dentry, &realpath);
 	}
 
+	if (realpath.dentry->d_flags & DCACHE_OP_SELECT_INODE)
+		return realpath.dentry->d_op->d_select_inode(realpath.dentry, file_flags);
+
 	return d_backing_inode(realpath.dentry);
 }
 


Patches currently in stable-queue which might be from miklos@szeredi.hu are

queue-4.2/ovl-free-stack-of-paths-in-ovl_fill_super.patch
queue-4.2/ovl-fix-dentry-reference-leak.patch
queue-4.2/ovl-use-o_largefile-in-ovl_copy_up.patch
queue-4.2/ovl-free-lower_mnt-array-in-ovl_put_super.patch
queue-4.2/ovl-fix-open-in-stacked-overlay.patch

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2015-11-06  6:39 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-11-06  6:38 Patch "ovl: fix open in stacked overlay" has been added to the 4.2-stable tree gregkh

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).