* [PATCH] drm/i915: quirk backlight present on Macbook 4,1
@ 2015-11-05 9:49 Jani Nikula
2015-11-09 8:57 ` [Intel-gfx] [PATCH] drm/i915: quirk backlight present on Macbook 4, 1 Ander Conselvan De Oliveira
0 siblings, 1 reply; 3+ messages in thread
From: Jani Nikula @ 2015-11-05 9:49 UTC (permalink / raw)
To: intel-gfx; +Cc: stable, jani.nikula, Daniel Nicoletti
Unsurprisingly macbooks have backlights, just the VBT doesn't seem to
know it in this case.
Reported-and-tested-by: Daniel Nicoletti <dantti12@gmail.com>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=88325
Fixes: c675949ec58c ("drm/i915: do not setup backlight if not available according to VBT")
Cc: stable@vger.kernel.org # v3.15+
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
drivers/gpu/drm/i915/intel_display.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index 7b3cfb64e7f6..b067147183e9 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -14875,6 +14875,9 @@ static struct intel_quirk intel_quirks[] = {
/* Apple Macbook 2,1 (Core 2 T7400) */
{ 0x27a2, 0x8086, 0x7270, quirk_backlight_present },
+ /* Apple Macbook 4,1 */
+ { 0x2a02, 0x106b, 0x00a1, quirk_backlight_present },
+
/* Toshiba CB35 Chromebook (Celeron 2955U) */
{ 0x0a06, 0x1179, 0x0a88, quirk_backlight_present },
--
2.1.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: quirk backlight present on Macbook 4, 1
2015-11-05 9:49 [PATCH] drm/i915: quirk backlight present on Macbook 4,1 Jani Nikula
@ 2015-11-09 8:57 ` Ander Conselvan De Oliveira
2015-11-16 12:49 ` Jani Nikula
0 siblings, 1 reply; 3+ messages in thread
From: Ander Conselvan De Oliveira @ 2015-11-09 8:57 UTC (permalink / raw)
To: Jani Nikula, intel-gfx; +Cc: Daniel Nicoletti, stable
Reviewed-by: Ander Conselvan de Oliveira <conselvan2@gmail.com>
On Thu, 2015-11-05 at 11:49 +0200, Jani Nikula wrote:
> Unsurprisingly macbooks have backlights, just the VBT doesn't seem to
> know it in this case.
>
> Reported-and-tested-by: Daniel Nicoletti <dantti12@gmail.com>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=88325
> Fixes: c675949ec58c ("drm/i915: do not setup backlight if not available
> according to VBT")
> Cc: stable@vger.kernel.org # v3.15+
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---
> drivers/gpu/drm/i915/intel_display.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c
> b/drivers/gpu/drm/i915/intel_display.c
> index 7b3cfb64e7f6..b067147183e9 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -14875,6 +14875,9 @@ static struct intel_quirk intel_quirks[] = {
> /* Apple Macbook 2,1 (Core 2 T7400) */
> { 0x27a2, 0x8086, 0x7270, quirk_backlight_present },
>
> + /* Apple Macbook 4,1 */
> + { 0x2a02, 0x106b, 0x00a1, quirk_backlight_present },
> +
> /* Toshiba CB35 Chromebook (Celeron 2955U) */
> { 0x0a06, 0x1179, 0x0a88, quirk_backlight_present },
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: quirk backlight present on Macbook 4, 1
2015-11-09 8:57 ` [Intel-gfx] [PATCH] drm/i915: quirk backlight present on Macbook 4, 1 Ander Conselvan De Oliveira
@ 2015-11-16 12:49 ` Jani Nikula
0 siblings, 0 replies; 3+ messages in thread
From: Jani Nikula @ 2015-11-16 12:49 UTC (permalink / raw)
To: Ander Conselvan De Oliveira, intel-gfx; +Cc: Daniel Nicoletti, stable
On Mon, 09 Nov 2015, Ander Conselvan De Oliveira <conselvan2@gmail.com> wrote:
> Reviewed-by: Ander Conselvan de Oliveira <conselvan2@gmail.com>
Pushed to drm-intel-fixes, thanks for the review.
BR,
Jani.
>
> On Thu, 2015-11-05 at 11:49 +0200, Jani Nikula wrote:
>> Unsurprisingly macbooks have backlights, just the VBT doesn't seem to
>> know it in this case.
>>
>> Reported-and-tested-by: Daniel Nicoletti <dantti12@gmail.com>
>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=88325
>> Fixes: c675949ec58c ("drm/i915: do not setup backlight if not available
>> according to VBT")
>> Cc: stable@vger.kernel.org # v3.15+
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>> ---
>> drivers/gpu/drm/i915/intel_display.c | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/i915/intel_display.c
>> b/drivers/gpu/drm/i915/intel_display.c
>> index 7b3cfb64e7f6..b067147183e9 100644
>> --- a/drivers/gpu/drm/i915/intel_display.c
>> +++ b/drivers/gpu/drm/i915/intel_display.c
>> @@ -14875,6 +14875,9 @@ static struct intel_quirk intel_quirks[] = {
>> /* Apple Macbook 2,1 (Core 2 T7400) */
>> { 0x27a2, 0x8086, 0x7270, quirk_backlight_present },
>>
>> + /* Apple Macbook 4,1 */
>> + { 0x2a02, 0x106b, 0x00a1, quirk_backlight_present },
>> +
>> /* Toshiba CB35 Chromebook (Celeron 2955U) */
>> { 0x0a06, 0x1179, 0x0a88, quirk_backlight_present },
>>
--
Jani Nikula, Intel Open Source Technology Center
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-11-16 12:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-11-05 9:49 [PATCH] drm/i915: quirk backlight present on Macbook 4,1 Jani Nikula
2015-11-09 8:57 ` [Intel-gfx] [PATCH] drm/i915: quirk backlight present on Macbook 4, 1 Ander Conselvan De Oliveira
2015-11-16 12:49 ` Jani Nikula
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).