From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com ([192.55.52.88]:1587 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161060AbbKTAve (ORCPT ); Thu, 19 Nov 2015 19:51:34 -0500 From: "Williams, Dan J" To: "axboe@fb.com" CC: "linux-kernel@vger.kernel.org" , "linux-nvdimm@lists.01.org" , "linux-block@vger.kernel.org" , "stable@vger.kernel.org" , "willy@linux.intel.com" , "viro@zeniv.linux.org.uk" Subject: Re: [PATCH] block: protect rw_page against device teardown Date: Fri, 20 Nov 2015 00:51:30 +0000 Message-ID: <1447980689.20885.16.camel@intel.com> References: <201511200825.O2a2KLtg%fengguang.wu@intel.com> In-Reply-To: <201511200825.O2a2KLtg%fengguang.wu@intel.com> Content-Language: en-US Content-Type: text/plain; charset="utf-8" Content-ID: <91A6243B96404748A015C012D785A2B5@intel.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org List-ID: T24gRnJpLCAyMDE1LTExLTIwIGF0IDA4OjMyICswODAwLCBrYnVpbGQgdGVzdCByb2JvdCB3cm90 ZToNCj4gSGkgRGFuLA0KPiANCj4gW2F1dG8gYnVpbGQgdGVzdCBFUlJPUiBvbjogYmxvY2svZm9y LW5leHRdDQo+IFthbHNvIGJ1aWxkIHRlc3QgRVJST1Igb246IHY0LjQtcmMxIG5leHQtMjAxNTEx MTldDQoNClRoYW5rcyBrYnVpbGQgcm9ib3QhIDstKQ0KDQpJIGluZGVlZCBoYWQgcmViYXNlZCB0 aGlzIGluIG15IHRyZWUgaW4gZnJvbnQgb2YgYW5vdGhlciBwYXRjaCB0aGF0DQptYWRlIGJsa19x dWV1ZV9lbnRlcigpIHB1YmxpYy4gwqBHaXZlbiB0aGF0IG90aGVyIHBhdGNoIGlzIDQuNSBtYXRl cmlhbCwNCm1vdmUgdGhhdCBkZWNsYXJhdGlvbiBjaGFuZ2UgaW50byB0aGlzIHBhdGNoOg0KDQo4 PC0tLS0NClN1YmplY3Q6IGJsb2NrOiBwcm90ZWN0IHJ3X3BhZ2UgYWdhaW5zdCBkZXZpY2UgdGVh cmRvd24NCg0KRnJvbTogRGFuIFdpbGxpYW1zIDxkYW4uai53aWxsaWFtc0BpbnRlbC5jb20+DQoN CkZpeCB1c2UgYWZ0ZXIgZnJlZSBjcmFzaGVzIGxpa2UgdGhlIGZvbGxvd2luZzoNCg0KwqBnZW5l cmFsIHByb3RlY3Rpb24gZmF1bHQ6IDAwMDAgWyMxXSBTTVANCsKgQ2FsbCBUcmFjZToNCsKgIFs8 ZmZmZmZmZmZhMDA1MDIxNj5dID8gcG1lbV9kb19idmVjLmlzcmEuMTIrMHhhNi8weGYwIFtuZF9w bWVtXQ0KwqAgWzxmZmZmZmZmZmEwMDUwYmEyPl0gcG1lbV9yd19wYWdlKzB4NDIvMHg4MCBbbmRf cG1lbV0NCsKgIFs8ZmZmZmZmZmY4MTI4ZmQ5MD5dIGJkZXZfcmVhZF9wYWdlKzB4NTAvMHg2MA0K wqAgWzxmZmZmZmZmZjgxMjk3MmYwPl0gZG9fbXBhZ2VfcmVhZHBhZ2UrMHg1MTAvMHg3NzANCsKg IFs8ZmZmZmZmZmY4MTI4ZmQyMD5dID8gSV9CREVWKzB4MjAvMHgyMA0KwqAgWzxmZmZmZmZmZjgx MWQ4NmRjPl0gPyBscnVfY2FjaGVfYWRkKzB4MWMvMHg1MA0KwqAgWzxmZmZmZmZmZjgxMjk3NjU3 Pl0gbXBhZ2VfcmVhZHBhZ2VzKzB4MTA3LzB4MTcwDQrCoCBbPGZmZmZmZmZmODEyOGZkMjA+XSA/ IElfQkRFVisweDIwLzB4MjANCsKgIFs8ZmZmZmZmZmY4MTI4ZmQyMD5dID8gSV9CREVWKzB4MjAv MHgyMA0KwqAgWzxmZmZmZmZmZjgxMjkwNThkPl0gYmxrZGV2X3JlYWRwYWdlcysweDFkLzB4MjAN CsKgIFs8ZmZmZmZmZmY4MTFkNjE1Zj5dIF9fZG9fcGFnZV9jYWNoZV9yZWFkYWhlYWQrMHgyOGYv MHgzMTANCsKgIFs8ZmZmZmZmZmY4MTFkNjAzOT5dID8gX19kb19wYWdlX2NhY2hlX3JlYWRhaGVh ZCsweDE2OS8weDMxMA0KwqAgWzxmZmZmZmZmZjgxMWM1YWJkPl0gPyBwYWdlY2FjaGVfZ2V0X3Bh Z2UrMHgyZC8weDFkMA0KwqAgWzxmZmZmZmZmZjgxMWM3NmY2Pl0gZmlsZW1hcF9mYXVsdCsweDM5 Ni8weDUzMA0KwqAgWzxmZmZmZmZmZjgxMWY4MTZlPl0gX19kb19mYXVsdCsweDRlLzB4ZjANCsKg IFs8ZmZmZmZmZmY4MTFmY2U3ZD5dIGhhbmRsZV9tbV9mYXVsdCsweDExYmQvMHgxYjUwDQoNCkNj OiA8c3RhYmxlQHZnZXIua2VybmVsLm9yZz4NCkNjOiBKZW5zIEF4Ym9lIDxheGJvZUBmYi5jb20+ DQpDYzogTWF0dGhldyBXaWxjb3ggPHdpbGx5QGxpbnV4LmludGVsLmNvbT4NCkNjOiBBbGV4YW5k ZXIgVmlybyA8dmlyb0B6ZW5pdi5saW51eC5vcmcudWs+DQpSZXBvcnRlZC1ieToga2J1aWxkIHRl c3Qgcm9ib3QgPGxrcEBpbnRlbC5jb20+DQpTaWduZWQtb2ZmLWJ5OiBEYW4gV2lsbGlhbXMgPGRh bi5qLndpbGxpYW1zQGludGVsLmNvbT4NCi0tLQ0KwqBibG9jay9ibGsuaMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoHzCoMKgwqDCoDIgLS0NCsKgZnMvYmxvY2tfZGV2LmPCoMKgwqDCoMKgwqDCoMKg wqB8wqDCoMKgMTggKysrKysrKysrKysrKysrKy0tDQrCoGluY2x1ZGUvbGludXgvYmxrZGV2Lmgg fMKgwqDCoMKgMiArKw0KwqAzIGZpbGVzIGNoYW5nZWQsIDE4IGluc2VydGlvbnMoKyksIDQgZGVs ZXRpb25zKC0pDQoNCmRpZmYgLS1naXQgYS9ibG9jay9ibGsuaCBiL2Jsb2NrL2Jsay5oDQppbmRl eCBkYTcyMmViNzg2ZGYuLmM0MzkyNmQzZDc0ZCAxMDA2NDQNCi0tLSBhL2Jsb2NrL2Jsay5oDQor KysgYi9ibG9jay9ibGsuaA0KQEAgLTcyLDggKzcyLDYgQEAgdm9pZCBibGtfZGVxdWV1ZV9yZXF1 ZXN0KHN0cnVjdCByZXF1ZXN0ICpycSk7DQrCoHZvaWQgX19ibGtfcXVldWVfZnJlZV90YWdzKHN0 cnVjdCByZXF1ZXN0X3F1ZXVlICpxKTsNCsKgYm9vbCBfX2Jsa19lbmRfYmlkaV9yZXF1ZXN0KHN0 cnVjdCByZXF1ZXN0ICpycSwgaW50IGVycm9yLA0KwqAJCQnCoMKgwqDCoHVuc2lnbmVkIGludCBu cl9ieXRlcywgdW5zaWduZWQgaW50IGJpZGlfYnl0ZXMpOw0KLWludCBibGtfcXVldWVfZW50ZXIo c3RydWN0IHJlcXVlc3RfcXVldWUgKnEsIGdmcF90IGdmcCk7DQotdm9pZCBibGtfcXVldWVfZXhp dChzdHJ1Y3QgcmVxdWVzdF9xdWV1ZSAqcSk7DQrCoHZvaWQgYmxrX2ZyZWV6ZV9xdWV1ZShzdHJ1 Y3QgcmVxdWVzdF9xdWV1ZSAqcSk7DQrCoA0KwqBzdGF0aWMgaW5saW5lIHZvaWQgYmxrX3F1ZXVl X2VudGVyX2xpdmUoc3RydWN0IHJlcXVlc3RfcXVldWUgKnEpDQpkaWZmIC0tZ2l0IGEvZnMvYmxv Y2tfZGV2LmMgYi9mcy9ibG9ja19kZXYuYw0KaW5kZXggYmIwZGZiMWM3YWYxLi5jYzBhZjEyYWNm OTQgMTAwNjQ0DQotLS0gYS9mcy9ibG9ja19kZXYuYw0KKysrIGIvZnMvYmxvY2tfZGV2LmMNCkBA IC0zOTAsOSArMzkwLDE3IEBAIGludCBiZGV2X3JlYWRfcGFnZShzdHJ1Y3QgYmxvY2tfZGV2aWNl ICpiZGV2LCBzZWN0b3JfdCBzZWN0b3IsDQrCoAkJCXN0cnVjdCBwYWdlICpwYWdlKQ0KwqB7DQrC oAljb25zdCBzdHJ1Y3QgYmxvY2tfZGV2aWNlX29wZXJhdGlvbnMgKm9wcyA9IGJkZXYtPmJkX2Rp c2stPmZvcHM7DQorCWludCByYyA9IC1FT1BOT1RTVVBQOw0KKw0KwqAJaWYgKCFvcHMtPnJ3X3Bh Z2UgfHwgYmRldl9nZXRfaW50ZWdyaXR5KGJkZXYpKQ0KLQkJcmV0dXJuIC1FT1BOT1RTVVBQOw0K LQlyZXR1cm4gb3BzLT5yd19wYWdlKGJkZXYsIHNlY3RvciArIGdldF9zdGFydF9zZWN0KGJkZXYp LCBwYWdlLCBSRUFEKTsNCisJCXJldHVybiByYzsNCisNCisJcmMgPSBibGtfcXVldWVfZW50ZXIo YmRldi0+YmRfcXVldWUsIEdGUF9LRVJORUwpOw0KKwlpZiAocmMpDQorCQlyZXR1cm4gcmM7DQor CXJjID0gb3BzLT5yd19wYWdlKGJkZXYsIHNlY3RvciArIGdldF9zdGFydF9zZWN0KGJkZXYpLCBw YWdlLCBSRUFEKTsNCisJYmxrX3F1ZXVlX2V4aXQoYmRldi0+YmRfcXVldWUpOw0KKwlyZXR1cm4g cmM7DQrCoH0NCsKgRVhQT1JUX1NZTUJPTF9HUEwoYmRldl9yZWFkX3BhZ2UpOw0KwqANCkBAIC00 MjEsMTQgKzQyOSwyMCBAQCBpbnQgYmRldl93cml0ZV9wYWdlKHN0cnVjdCBibG9ja19kZXZpY2Ug KmJkZXYsIHNlY3Rvcl90IHNlY3RvciwNCsKgCWludCByZXN1bHQ7DQrCoAlpbnQgcncgPSAod2Jj LT5zeW5jX21vZGUgPT0gV0JfU1lOQ19BTEwpID8gV1JJVEVfU1lOQyA6IFdSSVRFOw0KwqAJY29u c3Qgc3RydWN0IGJsb2NrX2RldmljZV9vcGVyYXRpb25zICpvcHMgPSBiZGV2LT5iZF9kaXNrLT5m b3BzOw0KKw0KwqAJaWYgKCFvcHMtPnJ3X3BhZ2UgfHwgYmRldl9nZXRfaW50ZWdyaXR5KGJkZXYp KQ0KwqAJCXJldHVybiAtRU9QTk9UU1VQUDsNCisJcmVzdWx0ID0gYmxrX3F1ZXVlX2VudGVyKGJk ZXYtPmJkX3F1ZXVlLCBHRlBfS0VSTkVMKTsNCisJaWYgKHJlc3VsdCkNCisJCXJldHVybiByZXN1 bHQ7DQorDQrCoAlzZXRfcGFnZV93cml0ZWJhY2socGFnZSk7DQrCoAlyZXN1bHQgPSBvcHMtPnJ3 X3BhZ2UoYmRldiwgc2VjdG9yICsgZ2V0X3N0YXJ0X3NlY3QoYmRldiksIHBhZ2UsIHJ3KTsNCsKg CWlmIChyZXN1bHQpDQrCoAkJZW5kX3BhZ2Vfd3JpdGViYWNrKHBhZ2UpOw0KwqAJZWxzZQ0KwqAJ CXVubG9ja19wYWdlKHBhZ2UpOw0KKwlibGtfcXVldWVfZXhpdChiZGV2LT5iZF9xdWV1ZSk7DQrC oAlyZXR1cm4gcmVzdWx0Ow0KwqB9DQrCoEVYUE9SVF9TWU1CT0xfR1BMKGJkZXZfd3JpdGVfcGFn ZSk7DQpkaWZmIC0tZ2l0IGEvaW5jbHVkZS9saW51eC9ibGtkZXYuaCBiL2luY2x1ZGUvbGludXgv YmxrZGV2LmgNCmluZGV4IDNmZTI3ZjhkOTFmMC4uYzBkMmI3OTI3YzFmIDEwMDY0NA0KLS0tIGEv aW5jbHVkZS9saW51eC9ibGtkZXYuaA0KKysrIGIvaW5jbHVkZS9saW51eC9ibGtkZXYuaA0KQEAg LTc5NCw2ICs3OTQsOCBAQCBleHRlcm4gaW50IHNjc2lfY21kX2lvY3RsKHN0cnVjdCByZXF1ZXN0 X3F1ZXVlICosIHN0cnVjdCBnZW5kaXNrICosIGZtb2RlX3QsDQrCoGV4dGVybiBpbnQgc2dfc2Nz aV9pb2N0bChzdHJ1Y3QgcmVxdWVzdF9xdWV1ZSAqLCBzdHJ1Y3QgZ2VuZGlzayAqLCBmbW9kZV90 LA0KwqAJCQnCoHN0cnVjdCBzY3NpX2lvY3RsX2NvbW1hbmQgX191c2VyICopOw0KwqANCitleHRl cm4gaW50IGJsa19xdWV1ZV9lbnRlcihzdHJ1Y3QgcmVxdWVzdF9xdWV1ZSAqcSwgZ2ZwX3QgZ2Zw KTsNCitleHRlcm4gdm9pZCBibGtfcXVldWVfZXhpdChzdHJ1Y3QgcmVxdWVzdF9xdWV1ZSAqcSk7 DQrCoGV4dGVybiB2b2lkIGJsa19zdGFydF9xdWV1ZShzdHJ1Y3QgcmVxdWVzdF9xdWV1ZSAqcSk7 DQrCoGV4dGVybiB2b2lkIGJsa19zdG9wX3F1ZXVlKHN0cnVjdCByZXF1ZXN0X3F1ZXVlICpxKTsN CsKgZXh0ZXJuIHZvaWQgYmxrX3N5bmNfcXVldWUoc3RydWN0IHJlcXVlc3RfcXVldWUgKnEpOw==