stable.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Patch "ARM: 8426/1: dma-mapping: add missing range check in dma_mmap()" has been added to the 4.3-stable tree
@ 2015-12-06  5:51 gregkh
  0 siblings, 0 replies; only message in thread
From: gregkh @ 2015-12-06  5:51 UTC (permalink / raw)
  To: m.szyprowski, gregkh, rmk+kernel; +Cc: stable, stable-commits


This is a note to let you know that I've just added the patch titled

    ARM: 8426/1: dma-mapping: add missing range check in dma_mmap()

to the 4.3-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     arm-8426-1-dma-mapping-add-missing-range-check-in-dma_mmap.patch
and it can be found in the queue-4.3 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@vger.kernel.org> know about it.


>From 371f0f085f629fc0f66695f572373ca4445a67ad Mon Sep 17 00:00:00 2001
From: Marek Szyprowski <m.szyprowski@samsung.com>
Date: Fri, 28 Aug 2015 09:41:39 +0100
Subject: ARM: 8426/1: dma-mapping: add missing range check in dma_mmap()

From: Marek Szyprowski <m.szyprowski@samsung.com>

commit 371f0f085f629fc0f66695f572373ca4445a67ad upstream.

dma_mmap() function in IOMMU-based dma-mapping implementation lacked
a check for valid range of mmap parameters (offset and buffer size), what
might have caused access beyond the allocated buffer. This patch fixes
this issue.

Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

---
 arch/arm/mm/dma-mapping.c |    5 +++++
 1 file changed, 5 insertions(+)

--- a/arch/arm/mm/dma-mapping.c
+++ b/arch/arm/mm/dma-mapping.c
@@ -1407,12 +1407,17 @@ static int arm_iommu_mmap_attrs(struct d
 	unsigned long uaddr = vma->vm_start;
 	unsigned long usize = vma->vm_end - vma->vm_start;
 	struct page **pages = __iommu_get_pages(cpu_addr, attrs);
+	unsigned long nr_pages = PAGE_ALIGN(size) >> PAGE_SHIFT;
+	unsigned long off = vma->vm_pgoff;
 
 	vma->vm_page_prot = __get_dma_pgprot(attrs, vma->vm_page_prot);
 
 	if (!pages)
 		return -ENXIO;
 
+	if (off >= nr_pages || (usize >> PAGE_SHIFT) > nr_pages - off)
+		return -ENXIO;
+
 	do {
 		int ret = vm_insert_page(vma, uaddr, *pages++);
 		if (ret) {


Patches currently in stable-queue which might be from m.szyprowski@samsung.com are

queue-4.3/arm-dts-add-vbus-regulator-to-usb2-phy-nodes-on-exynos3250-exynos4210-and-exynos4412-boards.patch
queue-4.3/arm-8427-1-dma-mapping-add-support-for-offset-parameter-in-dma_mmap.patch
queue-4.3/arm-8426-1-dma-mapping-add-missing-range-check-in-dma_mmap.patch

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2015-12-06  5:51 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-12-06  5:51 Patch "ARM: 8426/1: dma-mapping: add missing range check in dma_mmap()" has been added to the 4.3-stable tree gregkh

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).