From: <gregkh@linuxfoundation.org>
To: herbert@gondor.apana.org.au, davem@davemloft.net,
fweimer@redhat.com, gregkh@linuxfoundation.org,
hannes@stressinduktion.org, j.winkel@profihost.ag,
m.schinkel@profihost.ag, pmhahn@pmhahn.de, s.priebe@profihost.ag,
tglx@linutronix.de
Cc: <stable@vger.kernel.org>, <stable-commits@vger.kernel.org>
Subject: Patch "netlink: Add missing goto statement to netlink_insert" has been added to the 4.1-stable tree
Date: Tue, 08 Dec 2015 22:30:01 -0500 [thread overview]
Message-ID: <14496318017374@kroah.com> (raw)
In-Reply-To: <20151208061319.GA16209@gondor.apana.org.au>
This is a note to let you know that I've just added the patch titled
netlink: Add missing goto statement to netlink_insert
to the 4.1-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
netlink-add-missing-goto-statement-to-netlink_insert.patch
and it can be found in the queue-4.1 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@vger.kernel.org> know about it.
>From herbert@gondor.apana.org.au Tue Dec 8 22:28:59 2015
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Tue, 8 Dec 2015 14:13:19 +0800
Subject: netlink: Add missing goto statement to netlink_insert
To: Stefan Priebe - Profihost AG <s.priebe@profihost.ag>
Cc: Hannes Frederic Sowa <hannes@stressinduktion.org>, Florian Weimer <fweimer@redhat.com>, Thomas Gleixner <tglx@linutronix.de>, netdev@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, jannik Winkel <j.winkel@profihost.ag>, Marco Schinkel <m.schinkel@profihost.ag>, "David S. Miller" <davem@davemloft.net>, stable@vger.kernel.org
Message-ID: <20151208061319.GA16209@gondor.apana.org.au>
Content-Disposition: inline
From: Herbert Xu <herbert@gondor.apana.org.au>
The backport of 1f770c0a09da855a2b51af6d19de97fb955eca85 ("netlink:
Fix autobind race condition that leads to zero port ID") missed a
goto statement, which causes netlink to break subtly.
This was discovered by Stefan Priebe <s.priebe@profihost.ag>.
Fixes: 4e2776241766 ("netlink: Fix autobind race condition that...")
Reported-by: Stefan Priebe <s.priebe@profihost.ag>
Reported-by: Philipp Hahn <pmhahn@pmhahn.de>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Acked-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
net/netlink/af_netlink.c | 1 +
1 file changed, 1 insertion(+)
--- a/net/netlink/af_netlink.c
+++ b/net/netlink/af_netlink.c
@@ -1118,6 +1118,7 @@ static int netlink_insert(struct sock *s
if (err == -EEXIST)
err = -EADDRINUSE;
sock_put(sk);
+ goto err;
}
/* We need to ensure that the socket is hashed and visible. */
Patches currently in stable-queue which might be from herbert@gondor.apana.org.au are
queue-4.1/netlink-add-missing-goto-statement-to-netlink_insert.patch
prev parent reply other threads:[~2015-12-09 3:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <564DC4A5.70104@profihost.ag>
[not found] ` <564DCC4C.1090009@redhat.com>
[not found] ` <564E2852.8000200@profihost.ag>
[not found] ` <56530A42.6030609@profihost.ag>
[not found] ` <1448283451.4019628.447573353.3659E447@webmail.messagingengine.com>
[not found] ` <565EBDC1.1090808@profihost.ag>
[not found] ` <8737vlt6xb.fsf@stressinduktion.org>
[not found] ` <5661DAC4.8040909@profihost.ag>
[not found] ` <20151205010819.GA21889@gondor.apana.org.au>
[not found] ` <5664A102.2030602@profihost.ag>
2015-12-07 1:20 ` Asterisk deadlocks since Kernel 4.1 Herbert Xu
2015-12-07 6:58 ` Stefan Priebe - Profihost AG
2015-12-08 6:13 ` netlink: Add missing goto statement to netlink_insert Herbert Xu
2015-12-08 16:21 ` David Miller
2015-12-09 3:29 ` Greg KH
2015-12-09 3:30 ` gregkh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=14496318017374@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=davem@davemloft.net \
--cc=fweimer@redhat.com \
--cc=hannes@stressinduktion.org \
--cc=herbert@gondor.apana.org.au \
--cc=j.winkel@profihost.ag \
--cc=m.schinkel@profihost.ag \
--cc=pmhahn@pmhahn.de \
--cc=s.priebe@profihost.ag \
--cc=stable-commits@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).