From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:41470 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934112AbbLQWna (ORCPT ); Thu, 17 Dec 2015 17:43:30 -0500 Subject: Patch "tipc: Fix kfree_skb() of uninitialised pointer" has been added to the 4.3-stable tree To: ben@decadent.org.uk, davem@davemloft.net, gregkh@linuxfoundation.org Cc: , From: Date: Thu, 17 Dec 2015 14:43:28 -0800 In-Reply-To: <20151215212156.GQ28542@decadent.org.uk> Message-ID: <145039220822867@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org List-ID: This is a note to let you know that I've just added the patch titled tipc: Fix kfree_skb() of uninitialised pointer to the 4.3-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: tipc-fix-kfree_skb-of-uninitialised-pointer.patch and it can be found in the queue-4.3 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let know about it. >>From ben@decadent.org.uk Thu Dec 17 14:16:22 2015 From: Ben Hutchings Date: Tue, 15 Dec 2015 21:21:57 +0000 Subject: tipc: Fix kfree_skb() of uninitialised pointer To: Greg Kroah-Hartman Cc: stable@vger.kernel.org, ying.xue@windriver.com, "David S. Miller" Message-ID: <20151215212156.GQ28542@decadent.org.uk> Content-Disposition: inline From: Ben Hutchings Commit 7098356baca7 ("tipc: fix error handling of expanding buffer headroom") added a "goto tx_error". This is fine upstream, but when backported to 4.3 it results in attempting to free the clone before it has been allocated. In this early error case, no cleanup is needed. Signed-off-by: Ben Hutchings Signed-off-by: Greg Kroah-Hartman --- net/tipc/udp_media.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/net/tipc/udp_media.c +++ b/net/tipc/udp_media.c @@ -162,7 +162,7 @@ static int tipc_udp_send_msg(struct net if (skb_headroom(skb) < UDP_MIN_HEADROOM) { err = pskb_expand_head(skb, UDP_MIN_HEADROOM, 0, GFP_ATOMIC); if (err) - goto tx_error; + return err; } clone = skb_clone(skb, GFP_ATOMIC); Patches currently in stable-queue which might be from ben@decadent.org.uk are queue-4.3/tipc-fix-kfree_skb-of-uninitialised-pointer.patch queue-4.3/revert-vrf-fix-double-free-and-memory-corruption-on-register_netdevice-failure.patch queue-4.3/vrf-fix-double-free-and-memory-corruption-on-register_netdevice-failure.patch