From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de ([195.135.220.15]:60306 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752713AbbL2N2K (ORCPT ); Tue, 29 Dec 2015 08:28:10 -0500 Message-ID: <1451395560.15095.1.camel@suse.com> Subject: Re: [PATCH 1/1] usb: cdc-acm: handle unlinked urb in acm read callback From: Oliver Neukum To: Lu Baolu Cc: Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Tang Jian Qiang , stable@vger.kernel.org Date: Tue, 29 Dec 2015 14:26:00 +0100 In-Reply-To: <1451368002-2122-1-git-send-email-baolu.lu@linux.intel.com> References: <1451368002-2122-1-git-send-email-baolu.lu@linux.intel.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: stable-owner@vger.kernel.org List-ID: On Tue, 2015-12-29 at 13:46 +0800, Lu Baolu wrote: > In current acm driver, the bulk-in callback function ignores the > URBs unlinked in usb core. > > This causes unexpected data loss in some cases. For example, > runtime suspend entry will unlinked all urbs and set urb->status > to -ENOENT even those urbs might have data not processed yet. > Hence, data loss occurs. > > This patch lets bulk-in callback function handle unlinked urbs > to avoid data loss. > > Signed-off-by: Tang Jian Qiang > Signed-off-by: Lu Baolu > Cc: stable@vger.kernel.org Acked-by: Oliver Neukum