From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:48045 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932756AbcAZAwk (ORCPT ); Mon, 25 Jan 2016 19:52:40 -0500 Subject: Patch "ALSA: seq: Fix race at timer setup and close" has been added to the 3.14-stable tree To: tiwai@suse.de, dvyukov@google.com, gregkh@linuxfoundation.org Cc: , From: Date: Mon, 25 Jan 2016 16:52:38 -0800 Message-ID: <145376955890133@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org List-ID: This is a note to let you know that I've just added the patch titled ALSA: seq: Fix race at timer setup and close to the 3.14-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: alsa-seq-fix-race-at-timer-setup-and-close.patch and it can be found in the queue-3.14 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let know about it. >>From 3567eb6af614dac436c4b16a8d426f9faed639b3 Mon Sep 17 00:00:00 2001 From: Takashi Iwai Date: Tue, 12 Jan 2016 15:36:27 +0100 Subject: ALSA: seq: Fix race at timer setup and close From: Takashi Iwai commit 3567eb6af614dac436c4b16a8d426f9faed639b3 upstream. ALSA sequencer code has an open race between the timer setup ioctl and the close of the client. This was triggered by syzkaller fuzzer, and a use-after-free was caught there as a result. This patch papers over it by adding a proper queue->timer_mutex lock around the timer-related calls in the relevant code path. Reported-by: Dmitry Vyukov Tested-by: Dmitry Vyukov Signed-off-by: Takashi Iwai Signed-off-by: Greg Kroah-Hartman --- sound/core/seq/seq_queue.c | 2 ++ 1 file changed, 2 insertions(+) --- a/sound/core/seq/seq_queue.c +++ b/sound/core/seq/seq_queue.c @@ -144,8 +144,10 @@ static struct snd_seq_queue *queue_new(i static void queue_delete(struct snd_seq_queue *q) { /* stop and release the timer */ + mutex_lock(&q->timer_mutex); snd_seq_timer_stop(q->timer); snd_seq_timer_close(q); + mutex_unlock(&q->timer_mutex); /* wait until access free */ snd_use_lock_sync(&q->use_lock); /* release resources... */ Patches currently in stable-queue which might be from tiwai@suse.de are queue-3.14/alsa-hrtimer-fix-stall-by-hrtimer_cancel.patch queue-3.14/alsa-timer-harden-slave-timer-list-handling.patch queue-3.14/alsa-timer-fix-double-unlink-of-active_list.patch queue-3.14/alsa-control-avoid-kernel-warnings-from-tlv-ioctl-with-numid-0.patch queue-3.14/alsa-hda-realtek-fix-silent-headphone-output-on-macpro-4-1-v2.patch queue-3.14/alsa-rme96-fix-unexpected-volume-reset-after-rate-changes.patch queue-3.14/alsa-hda-set-skl-hda-controller-power-at-freeze-and-thaw.patch queue-3.14/alsa-hda-add-inverted-dmic-for-packard-bell-dots.patch queue-3.14/alsa-hda-add-intel-lewisburg-device-ids-audio.patch queue-3.14/alsa-seq-fix-race-at-timer-setup-and-close.patch queue-3.14/alsa-pcm-fix-snd_pcm_hw_params-struct-copy-in-compat-mode.patch queue-3.14/alsa-seq-fix-snd_seq_call_port_info_ioctl-in-compat-mode.patch queue-3.14/alsa-seq-fix-missing-null-check-at-remove_events-ioctl.patch queue-3.14/alsa-timer-fix-race-among-timer-ioctls.patch queue-3.14/alsa-hda-apply-pin-fixup-for-hp-probook-6550b.patch