From: <gregkh@linuxfoundation.org>
To: edumazet@google.com, davej@codemonkey.org.uk,
davem@davemloft.net, gregkh@linuxfoundation.org
Cc: <stable@vger.kernel.org>, <stable-commits@vger.kernel.org>
Subject: Patch "ipv6: tcp: add rcu locking in tcp_v6_send_synack()" has been added to the 4.3-stable tree
Date: Tue, 26 Jan 2016 22:29:10 -0800 [thread overview]
Message-ID: <1453876150153159@kroah.com> (raw)
This is a note to let you know that I've just added the patch titled
ipv6: tcp: add rcu locking in tcp_v6_send_synack()
to the 4.3-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
ipv6-tcp-add-rcu-locking-in-tcp_v6_send_synack.patch
and it can be found in the queue-4.3 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@vger.kernel.org> know about it.
>From foo@baz Tue Jan 26 21:35:03 PST 2016
From: Eric Dumazet <edumazet@google.com>
Date: Fri, 8 Jan 2016 09:35:51 -0800
Subject: ipv6: tcp: add rcu locking in tcp_v6_send_synack()
From: Eric Dumazet <edumazet@google.com>
[ Upstream commit 3e4006f0b86a5ae5eb0e8215f9a9e1db24506977 ]
When first SYNACK is sent, we already hold rcu_read_lock(), but this
is not true if a SYNACK is retransmitted, as a timer (soft) interrupt
does not hold rcu_read_lock()
Fixes: 45f6fad84cc30 ("ipv6: add complete rcu protection around np->opt")
Reported-by: Dave Jones <davej@codemonkey.org.uk>
Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
net/ipv6/tcp_ipv6.c | 2 ++
1 file changed, 2 insertions(+)
--- a/net/ipv6/tcp_ipv6.c
+++ b/net/ipv6/tcp_ipv6.c
@@ -462,8 +462,10 @@ static int tcp_v6_send_synack(struct soc
fl6->flowlabel = ip6_flowlabel(ipv6_hdr(ireq->pktopts));
skb_set_queue_mapping(skb, queue_mapping);
+ rcu_read_lock();
err = ip6_xmit(sk, skb, fl6, rcu_dereference(np->opt),
np->tclass);
+ rcu_read_unlock();
err = net_xmit_eval(err);
}
Patches currently in stable-queue which might be from edumazet@google.com are
queue-4.3/tcp-fix-zero-cwnd-in-tcp_cwnd_reduction.patch
queue-4.3/net-sched-fix-missing-free-per-cpu-on-qstats.patch
queue-4.3/ipv6-tcp-add-rcu-locking-in-tcp_v6_send_synack.patch
queue-4.3/ipv6-update-skb-csum-when-ce-mark-is-propagated.patch
queue-4.3/net-possible-use-after-free-in-dst_release.patch
queue-4.3/phonet-properly-unshare-skbs-in-phonet_rcv.patch
queue-4.3/tcp_yeah-don-t-set-ssthresh-below-2.patch
reply other threads:[~2016-01-27 6:34 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1453876150153159@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=davej@codemonkey.org.uk \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=stable-commits@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).