* Patch "xhci: fix placement of call to usb_disabled()" has been added to the 3.10-stable tree
@ 2016-01-31 19:14 gregkh
0 siblings, 0 replies; only message in thread
From: gregkh @ 2016-01-31 19:14 UTC (permalink / raw)
To: gregkh, luis.henriques; +Cc: stable, stable-commits
This is a note to let you know that I've just added the patch titled
xhci: fix placement of call to usb_disabled()
to the 3.10-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
xhci-fix-placement-of-call-to-usb_disabled.patch
and it can be found in the queue-3.10 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@vger.kernel.org> know about it.
>From foo@baz Sun Jan 31 11:11:58 PST 2016
Date: Sun, 31 Jan 2016 11:11:58 -0800
To: Greg KH <gregkh@linuxfoundation.org>
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: xhci: fix placement of call to usb_disabled()
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
In the backport of 1eaf35e4dd592c59041bc1ed3248c46326da1f5f, the call to
usb_disabled() was too late, after we had already done some allocation.
Move that call to the top of the function instead, making the logic
match what is intended and is in the original patch.
Reported-by: Luis Henriques <luis.henriques@canonical.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
drivers/usb/host/xhci.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
--- a/drivers/usb/host/xhci.c
+++ b/drivers/usb/host/xhci.c
@@ -4788,6 +4788,9 @@ static int __init xhci_hcd_init(void)
{
int retval;
+ if (usb_disabled())
+ return -ENODEV;
+
retval = xhci_register_pci();
if (retval < 0) {
printk(KERN_DEBUG "Problem registering PCI driver.");
@@ -4816,9 +4819,6 @@ static int __init xhci_hcd_init(void)
/* xhci_run_regs has eight fields and embeds 128 xhci_intr_regs */
BUILD_BUG_ON(sizeof(struct xhci_run_regs) != (8+8*128)*32/8);
- if (usb_disabled())
- return -ENODEV;
-
return 0;
unreg_pci:
xhci_unregister_pci();
Patches currently in stable-queue which might be from gregkh@linuxfoundation.org are
queue-3.10/xhci-fix-placement-of-call-to-usb_disabled.patch
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2016-01-31 19:14 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-31 19:14 Patch "xhci: fix placement of call to usb_disabled()" has been added to the 3.10-stable tree gregkh
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).