From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ozlabs.org ([103.22.144.67]:58583 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751285AbcBOJXD (ORCPT ); Mon, 15 Feb 2016 04:23:03 -0500 Message-ID: <1455528175.26205.1.camel@ellerman.id.au> Subject: Re: [3.19.y-ckt stable][dropping] Patch "powerpc: Simplify module TOC handling" From: Michael Ellerman To: Kamal Mostafa , Alan Modra Cc: kernel-team@lists.ubuntu.com, Sasha Levin , stable , Anton Blanchard Date: Mon, 15 Feb 2016 20:22:55 +1100 In-Reply-To: <1455221508.24361.23.camel@fourier> References: <1455057708-5329-1-git-send-email-kamal@canonical.com> <20160209231930.GA11459@bubble.grove.modra.org> <1455134004.8525.12.camel@fourier> <1455221508.24361.23.camel@fourier> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: stable-owner@vger.kernel.org List-ID: On Thu, 2016-02-11 at 12:11 -0800, Kamal Mostafa wrote: > > > On Tue, Feb 09, 2016 at 02:41:48PM -0800, Kamal Mostafa wrote: > > > > This is a note to let you know that I have just added a patch titled > > > > powerpc: Simplify module TOC handling > > > > to the linux-3.19.y-queue branch of the 3.19.y-ckt extended stable tree > > > On Wed, 2016-02-10 at 09:49 +1030, Alan Modra wrote: > > > Please also add this followup patch by Anton: > > > https://build.opensuse.org/package/view_file/Base:System/kmod/depmod-Ignore_PowerPC64_ABIv2_.TOC.symbol.patch > > > depmod: Ignore PowerPC64 ABIv2 .TOC. symbol > > On Wed, 2016-02-10 at 11:53 -0800, Kamal Mostafa wrote: > > > That ("depmod: Ignore PowerPC64 ABIv2 .TOC. symbol") is a patch to > > 'kmod' which is not part of the kernel source tree. So I can't include > > that patch in a stable kernel release -- each distro's kmod package > > would have to do that. > > Okay, I now realize that the stable kernel patch ("powerpc: Simplify > module TOC handling") will break the ppc64 build for hosts that don't > have that depmod patch. > > So, pending any further discussion here, I'm going to drop this from 4.2 > and 3.19 -stable after all: > > c153693d powerpc: Simplify module TOC handling Yep, OK. For some reason my build process didn't catch the failure, so I didn't realise the depmod patch was required when I merged it. The dilemma we have now is if we don't backport it then the branches that don't have it won't be able to build with future binutils. But I guess that's a problem for the future whereas the depmod breakage is happening right now. cheers