From: Andreas Gruenbacher <agruenba@redhat.com>
To: unlisted-recipients:; (no To-header on input)
Cc: Wei Yongjun <yongjun_wei@trendmicro.com.cn>, <stable@vger.kernel.org>
Subject: [PATCH] vfs: fix missing unlock on error in simple_xattr_list()
Date: Fri, 19 Feb 2016 15:00:18 +0100 [thread overview]
Message-ID: <1455890418-18353-2-git-send-email-agruenba@redhat.com> (raw)
In-Reply-To: <1455890418-18353-1-git-send-email-agruenba@redhat.com>
From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Add the missing unlock before return from function simple_xattr_list()
in the error handling case.
Fixes: 786534b92f3c (tmpfs: listxattr should include POSIX ACL xattrs)
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Reviewed-by: Andreas Gruenbacher <agruenba@redhat.com>
Cc: <stable@vger.kernel.org> # 4.4
---
fs/xattr.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/fs/xattr.c b/fs/xattr.c
index 07d0e47..d4f8487 100644
--- a/fs/xattr.c
+++ b/fs/xattr.c
@@ -964,8 +964,10 @@ ssize_t simple_xattr_list(struct inode *inode, struct simple_xattrs *xattrs,
continue;
err = xattr_list_one(&buffer, &remaining_size, xattr->name);
- if (err)
+ if (err) {
+ spin_unlock(&xattrs->lock);
return err;
+ }
}
spin_unlock(&xattrs->lock);
--
2.4.3
parent reply other threads:[~2016-02-19 14:00 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1455890418-18353-1-git-send-email-agruenba@redhat.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1455890418-18353-2-git-send-email-agruenba@redhat.com \
--to=agruenba@redhat.com \
--cc=stable@vger.kernel.org \
--cc=yongjun_wei@trendmicro.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).