Linux kernel -stable discussions
 help / color / mirror / Atom feed
From: "Coelho, Luciano" <luciano.coelho@intel.com>
To: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
	"stable@vger.kernel.org" <stable@vger.kernel.org>,
	"Grumbach, Emmanuel" <emmanuel.grumbach@intel.com>
Subject: Re: FAILED: patch "[PATCH] iwlwifi: mvm: don't allow sched scans without matches to be" failed to apply to 4.4-stable tree
Date: Tue, 1 Mar 2016 19:27:41 +0000	[thread overview]
Message-ID: <1456860461.28365.15.camel@intel.com> (raw)
In-Reply-To: <145685795842149@kroah.com>

Hi Greg,

This is strange... I just tried to cherry-pick it on top of 4.4.3 and
it applied cleanly.

Do you want me to send it again anyway?

--
Cheers,
Luca.

On Tue, 2016-03-01 at 10:45 -0800, gregkh@linuxfoundation.org wrote:
> The patch below does not apply to the 4.4-stable tree.
> If someone wants it applied there, or to any other stable or longterm
> tree, then please email the backport, including the original git
> commit
> id to <stable@vger.kernel.org>.
> 
> thanks,
> 
> greg k-h
> 
> ------------------ original commit in Linus's tree ------------------
> 
> From 5e56276e7555b34550d51459a801ff75eca8b907 Mon Sep 17 00:00:00
> 2001
> From: Luca Coelho <luciano.coelho@intel.com>
> Date: Tue, 2 Feb 2016 15:11:15 +0200
> Subject: [PATCH] iwlwifi: mvm: don't allow sched scans without
> matches to be
>  started
> 
> The firmware can perform a scheduled scan with not matchsets passed,
> but it can't send notification that results were found.  Since the
> userspace then cannot know when we got new results and the firmware
> wouldn't trigger a wake in case we are sleeping, it's better not to
> allow scans without matchsets.
> 
> This fixes https://bugzilla.kernel.org/show_bug.cgi?id=110831
> 
> Cc: <stable@vger.kernel.org> [3.17+]
> Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
> Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
> 
> diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/scan.c
> b/drivers/net/wireless/intel/iwlwifi/mvm/scan.c
> index 9a15642f80dd..ea1e177c2ea1 100644
> --- a/drivers/net/wireless/intel/iwlwifi/mvm/scan.c
> +++ b/drivers/net/wireless/intel/iwlwifi/mvm/scan.c
> @@ -1298,6 +1298,10 @@ int iwl_mvm_sched_scan_start(struct iwl_mvm
> *mvm,
>  		return -EBUSY;
>  	}
>  
> +	/* we don't support "match all" in the firmware */
> +	if (!req->n_match_sets)
> +		return -EOPNOTSUPP;
> +
>  	ret = iwl_mvm_check_running_scans(mvm, type);
>  	if (ret)
>  		return ret;
> 

  reply	other threads:[~2016-03-01 19:27 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-01 18:45 FAILED: patch "[PATCH] iwlwifi: mvm: don't allow sched scans without matches to be" failed to apply to 4.4-stable tree gregkh
2016-03-01 19:27 ` Coelho, Luciano [this message]
2016-03-01 19:42   ` gregkh
2016-03-01 19:45     ` Coelho, Luciano
2016-03-01 19:52       ` Coelho, Luciano
2016-03-01 20:02         ` gregkh
2016-03-01 20:07           ` Coelho, Luciano
2016-03-01 20:11             ` gregkh
2016-03-01 20:19               ` Grumbach, Emmanuel
2016-03-01 20:23                 ` Coelho, Luciano
2016-03-01 20:24                 ` gregkh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1456860461.28365.15.camel@intel.com \
    --to=luciano.coelho@intel.com \
    --cc=emmanuel.grumbach@intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox