* Patch "ALSA: hdsp: Fix wrong boolean ctl value accesses" has been added to the 3.10-stable tree
@ 2016-03-05 21:20 gregkh
0 siblings, 0 replies; only message in thread
From: gregkh @ 2016-03-05 21:20 UTC (permalink / raw)
To: tiwai, gregkh; +Cc: stable, stable-commits
This is a note to let you know that I've just added the patch titled
ALSA: hdsp: Fix wrong boolean ctl value accesses
to the 3.10-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
alsa-hdsp-fix-wrong-boolean-ctl-value-accesses.patch
and it can be found in the queue-3.10 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@vger.kernel.org> know about it.
>From eab3c4db193f5fcccf70e884de9a922ca2c63d80 Mon Sep 17 00:00:00 2001
From: Takashi Iwai <tiwai@suse.de>
Date: Mon, 29 Feb 2016 14:26:43 +0100
Subject: ALSA: hdsp: Fix wrong boolean ctl value accesses
From: Takashi Iwai <tiwai@suse.de>
commit eab3c4db193f5fcccf70e884de9a922ca2c63d80 upstream.
snd-hdsp driver accesses enum item values (int) instead of boolean
values (long) wrongly for some ctl elements. This patch fixes them.
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
sound/pci/rme9652/hdsp.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- a/sound/pci/rme9652/hdsp.c
+++ b/sound/pci/rme9652/hdsp.c
@@ -2923,7 +2923,7 @@ static int snd_hdsp_get_dds_offset(struc
{
struct hdsp *hdsp = snd_kcontrol_chip(kcontrol);
- ucontrol->value.enumerated.item[0] = hdsp_dds_offset(hdsp);
+ ucontrol->value.integer.value[0] = hdsp_dds_offset(hdsp);
return 0;
}
@@ -2935,7 +2935,7 @@ static int snd_hdsp_put_dds_offset(struc
if (!snd_hdsp_use_is_exclusive(hdsp))
return -EBUSY;
- val = ucontrol->value.enumerated.item[0];
+ val = ucontrol->value.integer.value[0];
spin_lock_irq(&hdsp->lock);
if (val != hdsp_dds_offset(hdsp))
change = (hdsp_set_dds_offset(hdsp, val) == 0) ? 1 : 0;
Patches currently in stable-queue which might be from tiwai@suse.de are
queue-3.10/alsa-hdspm-fix-zero-division.patch
queue-3.10/alsa-ctl-fix-ioctls-for-x32-abi.patch
queue-3.10/alsa-hdspm-fix-wrong-boolean-ctl-value-accesses.patch
queue-3.10/alsa-hdsp-fix-wrong-boolean-ctl-value-accesses.patch
queue-3.10/alsa-seq-oss-don-t-drain-at-closing-a-client.patch
queue-3.10/alsa-timer-fix-ioctls-for-x32-abi.patch
queue-3.10/alsa-timer-fix-broken-compat-timer-user-status-ioctl.patch
queue-3.10/alsa-rawmidi-fix-ioctls-x32-abi.patch
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2016-03-05 21:20 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-05 21:20 Patch "ALSA: hdsp: Fix wrong boolean ctl value accesses" has been added to the 3.10-stable tree gregkh
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).