From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:56000 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751084AbcCEVU6 (ORCPT ); Sat, 5 Mar 2016 16:20:58 -0500 Subject: Patch "ALSA: hdspm: Fix zero-division" has been added to the 3.14-stable tree To: tiwai@suse.de, gregkh@linuxfoundation.org Cc: , From: Date: Sat, 05 Mar 2016 13:20:56 -0800 Message-ID: <145721285611327@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org List-ID: This is a note to let you know that I've just added the patch titled ALSA: hdspm: Fix zero-division to the 3.14-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: alsa-hdspm-fix-zero-division.patch and it can be found in the queue-3.14 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let know about it. >>From c1099c3294c2344110085a38c50e478a5992b368 Mon Sep 17 00:00:00 2001 From: Takashi Iwai Date: Mon, 29 Feb 2016 14:32:42 +0100 Subject: ALSA: hdspm: Fix zero-division From: Takashi Iwai commit c1099c3294c2344110085a38c50e478a5992b368 upstream. HDSPM driver contains a code issuing zero-division potentially in system sample rate ctl code. This patch fixes it by not processing a zero or invalid rate value as a divisor, as well as excluding the invalid value to be passed via the given ctl element. Signed-off-by: Takashi Iwai Signed-off-by: Greg Kroah-Hartman --- sound/pci/rme9652/hdspm.c | 8 ++++++++ 1 file changed, 8 insertions(+) --- a/sound/pci/rme9652/hdspm.c +++ b/sound/pci/rme9652/hdspm.c @@ -1602,6 +1602,9 @@ static void hdspm_set_dds_value(struct h { u64 n; + if (snd_BUG_ON(rate <= 0)) + return; + if (rate >= 112000) rate /= 4; else if (rate >= 56000) @@ -2224,6 +2227,8 @@ static int hdspm_get_system_sample_rate( } else { /* slave mode, return external sample rate */ rate = hdspm_external_sample_rate(hdspm); + if (!rate) + rate = hdspm->system_sample_rate; } } @@ -2269,7 +2274,10 @@ static int snd_hdspm_put_system_sample_r ucontrol) { struct hdspm *hdspm = snd_kcontrol_chip(kcontrol); + int rate = ucontrol->value.integer.value[0]; + if (rate < 27000 || rate > 207000) + return -EINVAL; hdspm_set_dds_value(hdspm, ucontrol->value.integer.value[0]); return 0; } Patches currently in stable-queue which might be from tiwai@suse.de are queue-3.14/alsa-hdspm-fix-zero-division.patch queue-3.14/alsa-ctl-fix-ioctls-for-x32-abi.patch queue-3.14/alsa-hdspm-fix-wrong-boolean-ctl-value-accesses.patch queue-3.14/alsa-hdsp-fix-wrong-boolean-ctl-value-accesses.patch queue-3.14/alsa-seq-oss-don-t-drain-at-closing-a-client.patch queue-3.14/alsa-timer-fix-ioctls-for-x32-abi.patch queue-3.14/alsa-timer-fix-broken-compat-timer-user-status-ioctl.patch queue-3.14/alsa-rawmidi-fix-ioctls-x32-abi.patch