From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com ([134.134.136.65]:21836 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752063AbcDDRKB (ORCPT ); Mon, 4 Apr 2016 13:10:01 -0400 Message-ID: <1459789854.12167.6.camel@linux.intel.com> Subject: Re: [PATCH v3 01/15] dmaengine: dw: fix master selection From: Andy Shevchenko To: Vinod Koul Cc: Viresh Kumar , linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org, Rob Herring , Hans-Christian Egtvedt , Tejun Heo , Mark Brown , Greg Kroah-Hartman , Mark Rutland , Vineet Gupta , stable@vger.kernel.org Date: Mon, 04 Apr 2016 20:10:54 +0300 In-Reply-To: <20160404170337.GC3515@vkoul-mobl.iind.intel.com> References: <1458311094-94927-1-git-send-email-andriy.shevchenko@linux.intel.com> <1458311094-94927-2-git-send-email-andriy.shevchenko@linux.intel.com> <20160404170337.GC3515@vkoul-mobl.iind.intel.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org List-ID: On Mon, 2016-04-04 at 10:03 -0700, Vinod Koul wrote: > On Fri, Mar 18, 2016 at 04:24:40PM +0200, Andy Shevchenko wrote: > > > > + /* > > +  * We need controller-specific data to set up slave > > transfers. > > +  */ > > + BUG_ON(chan->private && !dw_dma_filter(chan, chan- > > >private)); > I don't think BUG_ON is apt here, gracefully failing and printing > that can > be better.. Hm, this is coming from the existing code. I would prefer to keep this one as is since it's targeted to stable@, and I may issue sequential patch to replace BUG_ON. Sounds okay? -- Andy Shevchenko Intel Finland Oy