From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f178.google.com ([209.85.192.178]:35091 "EHLO mail-pf0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752616AbcD2Anr (ORCPT ); Thu, 28 Apr 2016 20:43:47 -0400 Received: by mail-pf0-f178.google.com with SMTP id 77so8137040pfv.2 for ; Thu, 28 Apr 2016 17:43:47 -0700 (PDT) From: John Stultz To: lkml Cc: John Stultz , Mark Brown , Tyler Baker , Thierry Reding , Greg Kroah-Hartman , stable Subject: [RFC][PATCH 4.4-stable] regulator: core: Ensure we lock all regulators Date: Thu, 28 Apr 2016 17:43:37 -0700 Message-Id: <1461890617-29209-1-git-send-email-john.stultz@linaro.org> Sender: stable-owner@vger.kernel.org List-ID: It seems upstream commit 49a6bb7a1c09 ("regulator: core: Ensure we lock all regulators"), was missed when considering tagging for -stable. Without this varient of that patch (the original doesn't apply, due to a later fix to the same which was backported), I see double-unlock lockdep splats in the v4.4.8 based HiKey kernel. Cc: Mark Brown Cc: Tyler Baker Cc: Thierry Reding Cc: Greg Kroah-Hartman CC: stable # 4.4 only (I think) Fixes: 3c2c5fb9b99ca ("regulator: core: avoid unused variable warning") Originally-Reported-by: Tyler Baker Originally-by: Mark Brown Signed-off-by: John Stultz --- drivers/regulator/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c index 7b94b8e..732ac71 100644 --- a/drivers/regulator/core.c +++ b/drivers/regulator/core.c @@ -148,7 +148,7 @@ static void regulator_lock_supply(struct regulator_dev *rdev) { int i; - for (i = 0; rdev->supply; rdev = rdev_get_supply(rdev), i++) + for (i = 0; rdev; rdev = rdev_get_supply(rdev), i++) mutex_lock_nested(&rdev->mutex, i); } -- 1.9.1