stable.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Patch "IB/core: Fix oops in ib_cache_gid_set_default_gid" has been added to the 4.5-stable tree
@ 2016-05-02  0:02 gregkh
  0 siblings, 0 replies; only message in thread
From: gregkh @ 2016-05-02  0:02 UTC (permalink / raw)
  To: dledford, gregkh; +Cc: stable, stable-commits


This is a note to let you know that I've just added the patch titled

    IB/core: Fix oops in ib_cache_gid_set_default_gid

to the 4.5-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     ib-core-fix-oops-in-ib_cache_gid_set_default_gid.patch
and it can be found in the queue-4.5 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@vger.kernel.org> know about it.


>From f4e7de63ab273b6a5e35c82eb4fc6363c855ddd4 Mon Sep 17 00:00:00 2001
From: Doug Ledford <dledford@redhat.com>
Date: Fri, 22 Apr 2016 20:14:58 -0400
Subject: IB/core: Fix oops in ib_cache_gid_set_default_gid

From: Doug Ledford <dledford@redhat.com>

commit f4e7de63ab273b6a5e35c82eb4fc6363c855ddd4 upstream.

When we fail to find the default gid index, we can't continue
processing in this routine or else we will pass a negative
index to later routines resulting in invalid memory access
attempts and a kernel oops.

Fixes: 03db3a2d81e6 (IB/core: Add RoCE GID table management)
Signed-off-by: Doug Ledford <dledford@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

---
 drivers/infiniband/core/cache.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

--- a/drivers/infiniband/core/cache.c
+++ b/drivers/infiniband/core/cache.c
@@ -691,7 +691,8 @@ void ib_cache_gid_set_default_gid(struct
 			      NULL);
 
 		/* Coudn't find default GID location */
-		WARN_ON(ix < 0);
+		if (WARN_ON(ix < 0))
+			goto release;
 
 		zattr_type.gid_type = gid_type;
 


Patches currently in stable-queue which might be from dledford@redhat.com are

queue-4.5/ib-core-fix-oops-in-ib_cache_gid_set_default_gid.patch
queue-4.5/ib-security-restrict-use-of-the-write-interface.patch
queue-4.5/ib-mlx5-expose-correct-max_sge_rd-limit.patch

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2016-05-02  0:02 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-05-02  0:02 Patch "IB/core: Fix oops in ib_cache_gid_set_default_gid" has been added to the 4.5-stable tree gregkh

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).