stable.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johan Hovold <johan@kernel.org>
To: linux-usb@vger.kernel.org
Cc: stable@vger.kernel.org, Johan Hovold <johan@kernel.org>
Subject: [PATCH 0/8] USB: serial: fix interface URB leaks and use-after-free
Date: Sun,  8 May 2016 20:07:55 +0200	[thread overview]
Message-ID: <1462730883-9025-1-git-send-email-johan@kernel.org> (raw)

This series fixes a number of issues where resources were not properly
released on probe errors. Typically, URBs allocated and submitted in an
attach callback were never unlinked or released in a matching release
callback. This could lead to memory leaks and use-after-free bugs as
we could end up with unbound interfaces with active URBs.

Included is also a couple of minor fixes and clean ups of the keyspan
driver, and a fix of how we deal with minor-number exhaustion in core.

Johan


Johan Hovold (8):
  USB: serial: io_edgeport: fix memory leaks in attach error path
  USB: serial: io_edgeport: fix memory leaks in probe error path
  USB: serial: keyspan: fix use-after-free in probe error path
  USB: serial: keyspan: fix URB unlink
  USB: serial: keyspan: fix debug and error messages
  USB: serial: mxuport: fix use-after-free in probe error path
  USB: serial: quatech2: fix use-after-free in probe error path
  USB: serial: fix minor-number allocation

 drivers/usb/serial/io_edgeport.c | 56 +++++++++++++++++++++----------
 drivers/usb/serial/keyspan.c     | 72 ++++++++++++++++++++++------------------
 drivers/usb/serial/mxuport.c     | 10 ++++++
 drivers/usb/serial/quatech2.c    |  1 +
 drivers/usb/serial/usb-serial.c  |  3 +-
 5 files changed, 90 insertions(+), 52 deletions(-)

-- 
2.7.3


             reply	other threads:[~2016-05-08 18:08 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-08 18:07 Johan Hovold [this message]
2016-05-08 18:07 ` [PATCH 1/8] USB: serial: io_edgeport: fix memory leaks in attach error path Johan Hovold
2016-05-08 18:07 ` [PATCH 2/8] USB: serial: io_edgeport: fix memory leaks in probe " Johan Hovold
2016-05-08 18:07 ` [PATCH 3/8] USB: serial: keyspan: fix use-after-free " Johan Hovold
2016-05-08 18:07 ` [PATCH 4/8] USB: serial: keyspan: fix URB unlink Johan Hovold
2016-05-08 18:08 ` [PATCH 5/8] USB: serial: keyspan: fix debug and error messages Johan Hovold
2016-05-08 18:08 ` [PATCH 6/8] USB: serial: mxuport: fix use-after-free in probe error path Johan Hovold
2016-05-08 18:08 ` [PATCH 7/8] USB: serial: quatech2: " Johan Hovold
2016-05-08 18:08 ` [PATCH 8/8] USB: serial: fix minor-number allocation Johan Hovold
2016-05-09  5:26   ` Greg KH
2016-05-10  7:45     ` Johan Hovold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1462730883-9025-1-git-send-email-johan@kernel.org \
    --to=johan@kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).