From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de ([195.135.220.15]:45376 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754515AbcEQJR1 (ORCPT ); Tue, 17 May 2016 05:17:27 -0400 Message-ID: <1463476438.19237.3.camel@suse.com> Subject: Re: [PATCH] cdc-wdm: fix "out-of-sync" due to missing notifications From: Oliver Neukum To: =?ISO-8859-1?Q?Bj=F8rn?= Mork Cc: Greg Kroah-Hartman , linux-usb@vger.kernel.org, stable@vger.kernel.org Date: Tue, 17 May 2016 11:13:58 +0200 In-Reply-To: <87mvntevwy.fsf@nemi.mork.no> References: <1463153977-19771-1-git-send-email-bjorn@mork.no> <87mvntevwy.fsf@nemi.mork.no> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org List-ID: On Fri, 2016-05-13 at 18:59 +0200, Bjørn Mork wrote: > Bjørn Mork writes: > > > The driver enforces a strict one-to-one relationship between the > > received RESPONSE_AVAILABLE notifications and messages read from > > the device. At the same time, it will cancel the interrupt URB > > when there is no client holding the character device open. > > Never mind. Forget it. > > This patch breaks other devices again. The immediate and unconditional > reading make them barf. I guess it can be worked around by delaying the > flushing until at least one notification is received, but I obviously > have to test this theory thoroughly on all devices I have. Hi, I think the best approach would be to keep the interrupt URB always active. I didn't do this to conserve bandwidth, but if it makes devices work, it certainly would be the best option. Regards Oliver