From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:59939 "EHLO metis.ext.4.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752561AbcERMsj (ORCPT ); Wed, 18 May 2016 08:48:39 -0400 Message-ID: <1463575713.3639.29.camel@pengutronix.de> Subject: Re: [PATCH] Revert "drm/imx: Remove of_node assignment from ipuv3-crtc driver probe" From: Philipp Zabel To: Fabio Estevam Cc: Chris Ruehl , stable , Marcel Ziswiler , DRI mailing list , Fabio Estevam , Lothar =?ISO-8859-1?Q?Wa=DFmann?= Date: Wed, 18 May 2016 14:48:33 +0200 In-Reply-To: References: <1463505092-28018-1-git-send-email-fabio.estevam@nxp.com> <573BBF24.7080009@gtsys.com.hk> <1463560704.3639.12.camel@pengutronix.de> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: stable-owner@vger.kernel.org List-ID: Hi Fabio, Am Mittwoch, den 18.05.2016, 07:51 -0300 schrieb Fabio Estevam: > Hi Philipp, > > On Wed, May 18, 2016 at 5:38 AM, Philipp Zabel wrote: > > > Could you also test https://patchwork.kernel.org/patch/9081661/ ? > > With this patch applied I still do not get HDMI working on a mx6q sabresd board. Thank you for testing. The reason HDMI still doesn't work is that the ipuv3-crtcs get probed after dw_hdmi-imx, which then calls drm_of_find_possible_crtcs() in its .bind function. That expects crtc->port to point to the of_node, which is set by the call to imx_drm_add_crtc(), still to the crtc devices' of_node instead of the of_node in platform data. I'll send a new version. regards Philipp