From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:42395 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752574AbcFEU50 (ORCPT ); Sun, 5 Jun 2016 16:57:26 -0400 Subject: Patch "xfs: fix inode validity check in xfs_iflush_cluster" has been added to the 4.5-stable tree To: dchinner@redhat.com, bfoster@redhat.com, david@fromorbit.com, gregkh@linuxfoundation.org, hch@lst.de Cc: , From: Date: Sun, 05 Jun 2016 13:57:26 -0700 Message-ID: <1465160246254239@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org List-ID: This is a note to let you know that I've just added the patch titled xfs: fix inode validity check in xfs_iflush_cluster to the 4.5-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: xfs-fix-inode-validity-check-in-xfs_iflush_cluster.patch and it can be found in the queue-4.5 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let know about it. >>From 51b07f30a71c27405259a0248206ed4e22adbee2 Mon Sep 17 00:00:00 2001 From: Dave Chinner Date: Wed, 18 May 2016 13:54:22 +1000 Subject: xfs: fix inode validity check in xfs_iflush_cluster From: Dave Chinner commit 51b07f30a71c27405259a0248206ed4e22adbee2 upstream. Some careless idiot(*) wrote crap code in commit 1a3e8f3 ("xfs: convert inode cache lookups to use RCU locking") back in late 2010, and so xfs_iflush_cluster checks the wrong inode for whether it is still valid under RCU protection. Fix it to lock and check the correct inode. (*) Careless-idiot: Dave Chinner Discovered-by: Brain Foster Signed-off-by: Dave Chinner Reviewed-by: Christoph Hellwig Signed-off-by: Dave Chinner Signed-off-by: Greg Kroah-Hartman --- fs/xfs/xfs_inode.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) --- a/fs/xfs/xfs_inode.c +++ b/fs/xfs/xfs_inode.c @@ -3225,13 +3225,13 @@ xfs_iflush_cluster( * We need to check under the i_flags_lock for a valid inode * here. Skip it if it is not valid or the wrong inode. */ - spin_lock(&ip->i_flags_lock); - if (!ip->i_ino || + spin_lock(&iq->i_flags_lock); + if (!iq->i_ino || (XFS_INO_TO_AGINO(mp, iq->i_ino) & mask) != first_index) { - spin_unlock(&ip->i_flags_lock); + spin_unlock(&iq->i_flags_lock); continue; } - spin_unlock(&ip->i_flags_lock); + spin_unlock(&iq->i_flags_lock); /* * Do an un-protected check to see if the inode is dirty and Patches currently in stable-queue which might be from dchinner@redhat.com are queue-4.5/xfs-xfs_iflush_cluster-fails-to-abort-on-error.patch queue-4.5/xfs-disallow-rw-remount-on-fs-with-unknown-ro-compat-features.patch queue-4.5/xfs-fix-inode-validity-check-in-xfs_iflush_cluster.patch queue-4.5/xfs-skip-stale-inodes-in-xfs_iflush_cluster.patch queue-4.5/xfs-don-t-wrap-growfs-agfl-indexes.patch