From: "Nicholas A. Bellinger" <nab@linux-iscsi.org>
To: mchristi@redhat.com
Cc: target-devel@vger.kernel.org, bart.vanassche@sandisk.com,
stable@vger.kernel.org
Subject: Re: [PATCH 1/1] target: fix max_unmap_lba_count calc overflow
Date: Wed, 08 Jun 2016 22:20:18 -0700 [thread overview]
Message-ID: <1465449618.5365.141.camel@haakon3.risingtidesystems.com> (raw)
In-Reply-To: <1464916357-8008-1-git-send-email-mchristi@redhat.com>
On Thu, 2016-06-02 at 20:12 -0500, mchristi@redhat.com wrote:
> From: Mike Christie <mchristi@redhat.com>
>
> max_discard_sectors only 32bits, and some non scsi backend
> devices will set this to the max 0xffffffff, so we can end up
> overflowing during the max_unmap_lba_count calculation.
>
> This fixes a regression caused by my patch:
>
> commit 8a9ebe717a133ba7bc90b06047f43cc6b8bcb8b3
> Author: Mike Christie <mchristi@redhat.com>
> Date: Mon Jan 18 14:09:27 2016 -0600
>
> target: Fix WRITE_SAME/DISCARD conversion to linux 512b sectors
>
> which can result in extra discards being sent to due the overflow
> causing max_unmap_lba_count to be smaller than what the backing
> device can actually support.
>
> Signed-off-by: Mike Christie <mchristi@redhat.com>
> Cc: stable@vger.kernel.org
>
Applied to target-pending/master.
Thanks MNC + Bart.
prev parent reply other threads:[~2016-06-09 5:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-03 1:12 [PATCH 1/1] target: fix max_unmap_lba_count calc overflow mchristi
2016-06-03 21:15 ` Bart Van Assche
2016-06-09 5:20 ` Nicholas A. Bellinger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1465449618.5365.141.camel@haakon3.risingtidesystems.com \
--to=nab@linux-iscsi.org \
--cc=bart.vanassche@sandisk.com \
--cc=mchristi@redhat.com \
--cc=stable@vger.kernel.org \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox