From: Oliver Neukum <oneukum@suse.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Gerd Hoffmann <kraxel@redhat.com>,
Alan Stern <stern@rowland.harvard.edu>,
linux-scsi@vger.kernel.org, linux-usb@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH resend] USB: uas: Fix slave queue_depth not being set
Date: Mon, 13 Jun 2016 14:05:50 +0200 [thread overview]
Message-ID: <1465819550.15666.23.camel@suse.com> (raw)
In-Reply-To: <1464679083-2914-2-git-send-email-hdegoede@redhat.com>
On Tue, 2016-05-31 at 09:18 +0200, Hans de Goede wrote:
> Commit 198de51dbc34 ("USB: uas: Limit qdepth at the scsi-host level")
> removed the scsi_change_queue_depth() call from uas_slave_configure()
> assuming that the slave would inherit the host's queue_depth, which
> that commit sets to the same value.
>
> This is incorrect, without the scsi_change_queue_depth() call the slave's
> queue_depth defaults to 1, introducing a performance regression.
Hans, may I ask what become of this patch? I don't see it in the queue.
Regards
Oliver
next prev parent reply other threads:[~2016-06-13 12:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-31 7:18 [PATCH resend 0/1] USB: uas: Fix slave queue_depth not being set Hans de Goede
2016-05-31 7:18 ` [PATCH resend] " Hans de Goede
2016-06-13 12:05 ` Oliver Neukum [this message]
2016-06-13 12:56 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1465819550.15666.23.camel@suse.com \
--to=oneukum@suse.com \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=kraxel@redhat.com \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox