From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from shadbolt.e.decadent.org.uk ([88.96.1.126]:52914 "EHLO shadbolt.e.decadent.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750771AbcFNVXf (ORCPT ); Tue, 14 Jun 2016 17:23:35 -0400 Message-ID: <1465939407.3529.254.camel@decadent.org.uk> Subject: Re: [PATCH 3.2 31/46] IB/security: Restrict use of the write() interface From: Ben Hutchings To: Sudip Mukherjee , linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: akpm@linux-foundation.org, Linus Torvalds , Doug Ledford , Jason Gunthorpe , Jann Horn Date: Tue, 14 Jun 2016 22:23:27 +0100 In-Reply-To: <57607309.3000600@gmail.com> References: <57607309.3000600@gmail.com> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-V5aqS8U68zYcDWSezoUB" Mime-Version: 1.0 Sender: stable-owner@vger.kernel.org List-ID: --=-V5aqS8U68zYcDWSezoUB Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, 2016-06-14 at 22:11 +0100, Sudip Mukherjee wrote: > On Sunday 12 June 2016 10:34 PM, Ben Hutchings wrote: > > 3.2.81-rc1 review patch.=C2=A0=C2=A0If anyone has any objections, pleas= e let > > me know. > >=20 > > ------------------ > >=20 > > From: Jason Gunthorpe > >=20 > > commit e6bd18f57aad1a2d1ef40e646d03ed0f2515c9e3 upstream. > >=20 > > The drivers/infiniband stack uses write() as a replacement for > > bi-directional ioctl().=C2=A0=C2=A0This is not safe. There are ways to > > trigger write calls that result in the return structure that > > is normally written to user space being shunted off to user > > specified kernel memory instead. > >=20 >=20 > >=20 > > Signed-off-by: Ben Hutchings > > --- > > --- a/drivers/infiniband/core/ucm.c > > +++ b/drivers/infiniband/core/ucm.c > > @@ -48,6 +48,7 @@ > >=20 > > =C2=A0 #include > >=20 > > +#include >=20 > This is breaking the build. There is no rdma/ib.h . This backported patch adds it. > The file was created by: > 8d36eb01da5d ("RDMA/cma: Define native IB address") >=20 > build log is at: https://gitlab.com/sudipm/linux-next/builds/1771265 It looks like your patch queue tester doesn't account for patches that create new files. Ben. --=20 Ben Hutchings We get into the habit of living before acquiring the habit of thinking. =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0- A= lbert Camus --=-V5aqS8U68zYcDWSezoUB Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCgAGBQJXYHXPAAoJEOe/yOyVhhEJi1kQANZr81BEHktNgzoTT3FqMy2s x/0yBY6H7IDYyhdI0C8v/oMA1Mmw39nAA8y70fusxVARSyxaWdnbylEqH8Ai9Wld 49vFJcIO1vlOdTxmrZ06VG/vskE30tXlIRLDS3VQvawdDw4kEcPAl5bay6MsIz+4 i12V5WRZ+8v1ubt1U93wwncWyq1hdN1zAcIklLxsevu9IjWMMvOnQ7zGoVhPXH+8 RvSvLyhOcVeDzMrRoPOkzWbcVV1sec+mVEDKshA1dHQPDX89ksrnGCmsiDKzizWa 5HvduuNntah5vLK1kCDUDSiV2jiJKjwmeOgqxZM6bgMSfrbCMZNA+ZBtt2eSZJfE 0DYDtJHb1UvHW1n5eR+ASlRimJCmF9skKCJC0LdAy3Mc4evoIumU3mBXKnrkWZ6w nd4HctX9fLPPa8CKixOmKXL/IJ+KcH91ZGgmi354kVG548XjEIjyEkd0yV5cG2F0 CMQwGj3xH7dwBqHU6x14g23JwdMfiAJlWCa1fc8bYl+WwSJj1pAGzodlQGaVzZzJ UjH2fLmEV0l8tuvEwA0ZUX+39YGcJxmnHm5LSSXi86hMMLix9ZY9pETureqg5Puh jOQS+eZO5WXsYugMxwjpPq9gjfYBmdns7Kq3gtfILNinSHz+bTi4grlokggXP/jJ ZNxUDYSL8PKJ2TRKpRHM =HbLt -----END PGP SIGNATURE----- --=-V5aqS8U68zYcDWSezoUB--