stable.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Patch "bridge: Don't insert unnecessary local fdb entry on changing mac address" has been added to the 4.6-stable tree
@ 2016-06-17 15:36 gregkh
  0 siblings, 0 replies; only message in thread
From: gregkh @ 2016-06-17 15:36 UTC (permalink / raw)
  To: makita.toshiaki, davem, gregkh, nikolay; +Cc: stable, stable-commits


This is a note to let you know that I've just added the patch titled

    bridge: Don't insert unnecessary local fdb entry on changing mac address

to the 4.6-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     bridge-don-t-insert-unnecessary-local-fdb-entry-on-changing-mac-address.patch
and it can be found in the queue-4.6 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@vger.kernel.org> know about it.


>From foo@baz Fri Jun 17 08:34:39 PDT 2016
From: Toshiaki Makita <makita.toshiaki@lab.ntt.co.jp>
Date: Tue, 7 Jun 2016 19:14:17 +0900
Subject: bridge: Don't insert unnecessary local fdb entry on changing mac address

From: Toshiaki Makita <makita.toshiaki@lab.ntt.co.jp>

[ Upstream commit 0b148def403153a4d1565f1640356cb78ce5109f ]

The missing br_vlan_should_use() test caused creation of an unneeded
local fdb entry on changing mac address of a bridge device when there is
a vlan which is configured on a bridge port but not on the bridge
device.

Fixes: 2594e9064a57 ("bridge: vlan: add per-vlan struct and move to rhashtables")
Signed-off-by: Toshiaki Makita <makita.toshiaki@lab.ntt.co.jp>
Acked-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
 net/bridge/br_fdb.c |    2 ++
 1 file changed, 2 insertions(+)

--- a/net/bridge/br_fdb.c
+++ b/net/bridge/br_fdb.c
@@ -279,6 +279,8 @@ void br_fdb_change_mac_address(struct ne
 	 * change from under us.
 	 */
 	list_for_each_entry(v, &vg->vlan_list, vlist) {
+		if (!br_vlan_should_use(v))
+			continue;
 		f = __br_fdb_get(br, br->dev->dev_addr, v->vid);
 		if (f && f->is_local && !f->dst)
 			fdb_delete_local(br, NULL, f);


Patches currently in stable-queue which might be from makita.toshiaki@lab.ntt.co.jp are

queue-4.6/bridge-don-t-insert-unnecessary-local-fdb-entry-on-changing-mac-address.patch

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2016-06-17 15:36 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-06-17 15:36 Patch "bridge: Don't insert unnecessary local fdb entry on changing mac address" has been added to the 4.6-stable tree gregkh

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).