stable.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Patch "tipc: check nl sock before parsing nested attributes" has been added to the 4.6-stable tree
@ 2016-06-17 15:36 gregkh
  0 siblings, 0 replies; only message in thread
From: gregkh @ 2016-06-17 15:36 UTC (permalink / raw)
  To: richard.alpe, davem, gregkh, jon.maloy, sploving1; +Cc: stable, stable-commits


This is a note to let you know that I've just added the patch titled

    tipc: check nl sock before parsing nested attributes

to the 4.6-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     tipc-check-nl-sock-before-parsing-nested-attributes.patch
and it can be found in the queue-4.6 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@vger.kernel.org> know about it.


>From foo@baz Fri Jun 17 08:34:39 PDT 2016
From: Richard Alpe <richard.alpe@ericsson.com>
Date: Mon, 16 May 2016 11:14:54 +0200
Subject: tipc: check nl sock before parsing nested attributes

From: Richard Alpe <richard.alpe@ericsson.com>

[ Upstream commit 45e093ae2830cd1264677d47ff9a95a71f5d9f9c ]

Make sure the socket for which the user is listing publication exists
before parsing the socket netlink attributes.

Prior to this patch a call without any socket caused a NULL pointer
dereference in tipc_nl_publ_dump().

Tested-and-reported-by: Baozeng Ding <sploving1@gmail.com>
Signed-off-by: Richard Alpe <richard.alpe@ericsson.com>
Acked-by: Jon Maloy <jon.maloy@ericsson.cm>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
 net/tipc/socket.c |    3 +++
 1 file changed, 3 insertions(+)

--- a/net/tipc/socket.c
+++ b/net/tipc/socket.c
@@ -2807,6 +2807,9 @@ int tipc_nl_publ_dump(struct sk_buff *sk
 		if (err)
 			return err;
 
+		if (!attrs[TIPC_NLA_SOCK])
+			return -EINVAL;
+
 		err = nla_parse_nested(sock, TIPC_NLA_SOCK_MAX,
 				       attrs[TIPC_NLA_SOCK],
 				       tipc_nl_sock_policy);


Patches currently in stable-queue which might be from richard.alpe@ericsson.com are

queue-4.6/tipc-check-nl-sock-before-parsing-nested-attributes.patch
queue-4.6/tipc-fix-nametable-publication-field-in-nl-compat.patch

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2016-06-17 15:36 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-06-17 15:36 Patch "tipc: check nl sock before parsing nested attributes" has been added to the 4.6-stable tree gregkh

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).