From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtprelay4.synopsys.com ([198.182.47.9]:37062 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750710AbcF1FjF convert rfc822-to-8bit (ORCPT ); Tue, 28 Jun 2016 01:39:05 -0400 From: Alexey Brodkin To: Vineet Gupta CC: "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" , "linux-snps-arc@lists.infradead.org" Subject: Re: [PATCH] arc: warn only once if DW2_UNWIND is disabled Date: Tue, 28 Jun 2016 05:38:59 +0000 Message-ID: <1467092276.3231.7.camel@synopsys.com> References: <1466668839-28210-1-git-send-email-abrodkin@synopsys.com> <5771FD80.1090906@synopsys.com> In-Reply-To: <5771FD80.1090906@synopsys.com> Content-Language: en-US Content-Type: text/plain; charset="utf-7" Content-ID: <35E5E02B71F6CD418D906A4002234E48@internal.synopsys.com> Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org List-ID: Hi Vineet, On Tue, 2016-06-28 at 10:00 +-0530, Vineet Gupta wrote: +AD4- On Thursday 23 June 2016 01:30 PM, Alexey Brodkin wrote: +AD4- +AD4- +AD4- +AD4- If CONFIG+AF8-ARC+AF8-DW2+AF8-UNWIND is disabled every time arc+AF8-unwind+AF8-core() +AD4- +AD4- gets called following message gets printed in debug console: +AD4- +AD4- -----------------+AD4-8--------------- +AD4- +AD4- CONFIG+AF8-ARC+AF8-DW2+AF8-UNWIND needs to be enabled +AD4- +AD4- -----------------+AD4-8--------------- +AD4- +AD4- +AD4- +AD4- That message makes sense if user indeed wants to see a backtrace or +AD4- +AD4- get nice function call-graphs in perf but what if user disabled +AD4- +AD4- unwinder for the purpose? Why pollute his debug console? +AD4- +AD4- +AD4- +AD4- So instead we'll warn user about possibly missing feature once and +AD4- +AD4- let him decide if that was what he or she really wanted. +AD4- +AD4- +AD4- +AD4- Signed-off-by: Alexey Brodkin +ADw-abrodkin+AEA-synopsys.com+AD4- +AD4- +AD4- Cc: stable+AEA-vger.kernel.org+AKAAoABb-3.18+-+AF0- +AD4- +AD4- Does this really need to be stable backport ? I think it makes perfect sense for any kernel version because it saves debug console from being polluted with messages which most probably have no point (Ok I disabled unwinder in kernel config, why then spam me with proposals to enable it)? -Alexey