From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-000f0801.pphosted.com ([67.231.144.122]:34460 "EHLO mx0a-000f0801.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751550AbcGRUyd (ORCPT ); Mon, 18 Jul 2016 16:54:33 -0400 From: "Charles (Chas) Williams" To: CC: Kangjie Lu , Kangjie Lu , Greg Kroah-Hartman , "Charles (Chas) Williams" Subject: [PATCH 3.14.y 5/9] USB: usbfs: fix potential infoleak in devio Date: Mon, 18 Jul 2016 16:53:19 -0400 Message-ID: <1468875203-10816-5-git-send-email-ciwillia@brocade.com> In-Reply-To: <1468875203-10816-1-git-send-email-ciwillia@brocade.com> References: <1468875203-10816-1-git-send-email-ciwillia@brocade.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org List-ID: From: Kangjie Lu commit 681fef8380eb818c0b845fca5d2ab1dcbab114ee upstream. The stack object “ci” has a total size of 8 bytes. Its last 3 bytes are padding bytes which are not initialized and leaked to userland via “copy_to_user”. CVE-2016-4482 Signed-off-by: Kangjie Lu Signed-off-by: Greg Kroah-Hartman [ciwillia@brocade.com: backported to 3.14: adjusted context] Signed-off-by: Charles (Chas) Williams --- drivers/usb/core/devio.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/usb/core/devio.c b/drivers/usb/core/devio.c index 8016aaa..a787664 100644 --- a/drivers/usb/core/devio.c +++ b/drivers/usb/core/devio.c @@ -1104,10 +1104,11 @@ static int proc_getdriver(struct dev_state *ps, void __user *arg) static int proc_connectinfo(struct dev_state *ps, void __user *arg) { - struct usbdevfs_connectinfo ci = { - .devnum = ps->dev->devnum, - .slow = ps->dev->speed == USB_SPEED_LOW - }; + struct usbdevfs_connectinfo ci; + + memset(&ci, 0, sizeof(ci)); + ci.devnum = ps->dev->devnum; + ci.slow = ps->dev->speed == USB_SPEED_LOW; if (copy_to_user(arg, &ci, sizeof(ci))) return -EFAULT; -- 2.5.5