* Patch "ALSA: ctl: Stop notification after disconnection" has been added to the 4.4-stable tree
@ 2016-07-25 0:29 gregkh
0 siblings, 0 replies; only message in thread
From: gregkh @ 2016-07-25 0:29 UTC (permalink / raw)
To: tiwai, gregkh; +Cc: stable, stable-commits
This is a note to let you know that I've just added the patch titled
ALSA: ctl: Stop notification after disconnection
to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
alsa-ctl-stop-notification-after-disconnection.patch
and it can be found in the queue-4.4 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@vger.kernel.org> know about it.
>From f388cdcdd160687c6650833f286b9c89c50960ff Mon Sep 17 00:00:00 2001
From: Takashi Iwai <tiwai@suse.de>
Date: Fri, 8 Jul 2016 08:05:19 +0200
Subject: ALSA: ctl: Stop notification after disconnection
From: Takashi Iwai <tiwai@suse.de>
commit f388cdcdd160687c6650833f286b9c89c50960ff upstream.
snd_ctl_remove() has a notification for the removal event. It's
superfluous when done during the device got disconnected. Although
the notification itself is mostly harmless, it may potentially be
harmful, and should be suppressed. Actually some components PCM may
free ctl elements during the disconnect or free callbacks, thus it's
no theoretical issue.
This patch adds the check of card->shutdown flag for avoiding
unnecessary notifications after (or during) the disconnect.
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
sound/core/control.c | 2 ++
1 file changed, 2 insertions(+)
--- a/sound/core/control.c
+++ b/sound/core/control.c
@@ -160,6 +160,8 @@ void snd_ctl_notify(struct snd_card *car
if (snd_BUG_ON(!card || !id))
return;
+ if (card->shutdown)
+ return;
read_lock(&card->ctl_files_rwlock);
#if IS_ENABLED(CONFIG_SND_MIXER_OSS)
card->mixer_oss_change_count++;
Patches currently in stable-queue which might be from tiwai@suse.de are
queue-4.4/alsa-hda-fix-the-headset-mic-jack-detection-on-dell-machine.patch
queue-4.4/alsa-ctl-stop-notification-after-disconnection.patch
queue-4.4/alsa-dummy-fix-a-use-after-free-at-closing.patch
queue-4.4/alsa-timer-fix-negative-queue-usage-by-racy-accesses.patch
queue-4.4/alsa-hda-fix-use-after-free-after-module-unload.patch
queue-4.4/alsa-hda-realtek-add-new-pin-definition-in-alc225-pin-quirk-table.patch
queue-4.4/alsa-hda-add-pci-id-for-kabylake-h.patch
queue-4.4/alsa-pcm-free-chmap-at-pcm-free-callback-too.patch
queue-4.4/alsa-au88x0-fix-calculation-in-vortex_wtdma_bufshift.patch
queue-4.4/alsa-hda-realtek-add-lenovo-l460-to-docking-unit-fixup.patch
queue-4.4/alsa-echoaudio-fix-memory-allocation.patch
queue-4.4/alsa-hda-realtek-add-two-more-thinkpad-ids-5050-5053-for-tpt460-fixup.patch
queue-4.4/alsa-hda-fix-read-before-array-start.patch
queue-4.4/alsa-hda-add-amd-stoney-pci-id-with-proper-driver-caps.patch
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2016-07-25 0:29 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-07-25 0:29 Patch "ALSA: ctl: Stop notification after disconnection" has been added to the 4.4-stable tree gregkh
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).