From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:34126 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1945937AbcHRMny (ORCPT ); Thu, 18 Aug 2016 08:43:54 -0400 Subject: Patch "ALSA: hda: Fix krealloc() with __GFP_ZERO usage" has been added to the 4.4-stable tree To: tiwai@suse.de, gregkh@linuxfoundation.org, joe@perches.com Cc: , From: Date: Thu, 18 Aug 2016 14:43:57 +0200 Message-ID: <147152423724753@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org List-ID: This is a note to let you know that I've just added the patch titled ALSA: hda: Fix krealloc() with __GFP_ZERO usage to the 4.4-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: alsa-hda-fix-krealloc-with-__gfp_zero-usage.patch and it can be found in the queue-4.4 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let know about it. >>From 33baefe5e72f17a6df378e48196cd8cada11deec Mon Sep 17 00:00:00 2001 From: Takashi Iwai Date: Wed, 3 Aug 2016 15:13:00 +0200 Subject: ALSA: hda: Fix krealloc() with __GFP_ZERO usage From: Takashi Iwai commit 33baefe5e72f17a6df378e48196cd8cada11deec upstream. krealloc() doesn't work always properly with __GFP_ZERO flag as expected. For clearing the reallocated area, we need to clear explicitly instead. Reported-by: Joe Perches Signed-off-by: Takashi Iwai Signed-off-by: Greg Kroah-Hartman --- sound/hda/array.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) --- a/sound/hda/array.c +++ b/sound/hda/array.c @@ -21,13 +21,15 @@ void *snd_array_new(struct snd_array *ar return NULL; if (array->used >= array->alloced) { int num = array->alloced + array->alloc_align; + int oldsize = array->alloced * array->elem_size; int size = (num + 1) * array->elem_size; void *nlist; if (snd_BUG_ON(num >= 4096)) return NULL; - nlist = krealloc(array->list, size, GFP_KERNEL | __GFP_ZERO); + nlist = krealloc(array->list, size, GFP_KERNEL); if (!nlist) return NULL; + memset(nlist + oldsize, 0, size - oldsize); array->list = nlist; array->alloced = num; } Patches currently in stable-queue which might be from tiwai@suse.de are queue-4.4/alsa-hda-add-amd-bonaire-az-pci-id-with-proper-driver-caps.patch queue-4.4/alsa-hda-realtek-can-t-adjust-speaker-s-volume-on-a-dell-aio.patch queue-4.4/alsa-hda-fix-krealloc-with-__gfp_zero-usage.patch queue-4.4/alsa-hda-fix-headset-mic-detection-problem-for-two-dell-machines.patch