From: <gregkh@linuxfoundation.org>
To: abbotti@mev.co.uk, ben@decadent.org.uk,
gregkh@linuxfoundation.org, piel@delmic.com
Cc: <stable@vger.kernel.org>, <stable-commits@vger.kernel.org>
Subject: Patch "staging: comedi: ni_mio_common: fix wrong insn_write handler" has been added to the 3.14-stable tree
Date: Fri, 09 Sep 2016 16:36:30 +0200 [thread overview]
Message-ID: <1473431790228190@kroah.com> (raw)
In-Reply-To: <20160907143312.19224-1-abbotti@mev.co.uk>
This is a note to let you know that I've just added the patch titled
staging: comedi: ni_mio_common: fix wrong insn_write handler
to the 3.14-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
staging-comedi-ni_mio_common-fix-wrong-insn_write-handler.patch
and it can be found in the queue-3.14 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@vger.kernel.org> know about it.
>From abbotti@mev.co.uk Fri Sep 9 16:17:25 2016
From: Ian Abbott <abbotti@mev.co.uk>
Date: Wed, 7 Sep 2016 15:33:12 +0100
Subject: staging: comedi: ni_mio_common: fix wrong insn_write handler
To: stable@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Ben Hutchings <ben@decadent.org.uk>, Ian Abbott <abbotti@mev.co.uk>
Message-ID: <20160907143312.19224-1-abbotti@mev.co.uk>
From: Ian Abbott <abbotti@mev.co.uk>
commit 5ca05345c56cb979e1a25ab6146437002f95cac8 upstream.
For counter subdevices, the `s->insn_write` handler is being set to the
wrong function, `ni_tio_insn_read()`. It should be
`ni_tio_insn_write()`.
Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Reported-by: Éric Piel <piel@delmic.com>
Fixes: 10f74377eec3 ("staging: comedi: ni_tio: make ni_tio_winsn() a proper comedi (*insn_write)")
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
drivers/staging/comedi/drivers/ni_mio_common.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/staging/comedi/drivers/ni_mio_common.c
+++ b/drivers/staging/comedi/drivers/ni_mio_common.c
@@ -4404,7 +4404,7 @@ static int ni_E_init(struct comedi_devic
else
s->maxdata = 0xffffff;
s->insn_read = ni_tio_insn_read;
- s->insn_write = ni_tio_insn_read;
+ s->insn_write = ni_tio_insn_write;
s->insn_config = ni_tio_insn_config;
#ifdef PCIDMA
s->subdev_flags |= SDF_CMD_READ /* | SDF_CMD_WRITE */;
Patches currently in stable-queue which might be from abbotti@mev.co.uk are
queue-3.14/staging-comedi-ni_mio_common-fix-wrong-insn_write-handler.patch
next prev parent reply other threads:[~2016-09-09 14:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-07 14:33 [PATCH 3.14 to 3.16] staging: comedi: ni_mio_common: fix wrong insn_write handler Ian Abbott
2016-09-09 14:36 ` gregkh [this message]
2016-11-12 2:20 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1473431790228190@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=abbotti@mev.co.uk \
--cc=ben@decadent.org.uk \
--cc=piel@delmic.com \
--cc=stable-commits@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).