From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from s3.sipsolutions.net ([5.9.151.49]:51482 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932573AbcI0UGO (ORCPT ); Tue, 27 Sep 2016 16:06:14 -0400 Message-ID: <1475006766.5141.42.camel@sipsolutions.net> Subject: Re: Patch "hrtimer: Add support for CLOCK_MONOTONIC_RAW" has been added to the 4.4-stable tree From: Johannes Berg To: Felix Fietkau , Greg KH , Marc Zyngier Cc: christoffer.dall@linaro.org, tglx@linutronix.de, tn@semihalf.com, stable@vger.kernel.org, stable-commits@vger.kernel.org Date: Tue, 27 Sep 2016 22:06:06 +0200 In-Reply-To: <82143295-0fa6-6d19-4f92-e3973c607632@nbd.name> References: <1474986477241162@kroah.com> <20160927171212.2e75bb99@arm.com> <20160927180343.GA24916@kroah.com> <82143295-0fa6-6d19-4f92-e3973c607632@nbd.name> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org List-ID: On Tue, 2016-09-27 at 21:55 +0200, Felix Fietkau wrote: > > > Please drop that patch. It is utterly broken, and was reverted in > > > mainline with commit 82e88ff1ea94 ("hrtimer: Revert > > > CLOCK_MONOTONIC_RAW support"). Probably shouldn't be discussing it in this context, but ... Why did this also revert the illegal clock ID catching? That seems strange? Doesn't that mean that everything that specifies an otherwise not supported value will get HRTIMER_BASE_MONOTONIC? > > Ok, will do. > > > > Felix, this kind of means this isn't the fix you were looking for, > > any > > other ideas? > I guess I can send a mac80211_hwpatch to switch to CLOCK_MONOTONIC > instead and add Cc: stable. I had actually selected _RAW for a reason, you don't want the frame timings to be affected by clock adjustments? Arguably, it's rare that the clock is actually adjusted, and even if that does happen, chances are that nobody will actually care at that point in time, but ... What would it take to actually add real support? johannes