From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com ([192.55.52.120]:2488 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751041AbcJCHSH (ORCPT ); Mon, 3 Oct 2016 03:18:07 -0400 Message-ID: <1475479083.3067.3.camel@linux.intel.com> Subject: Re: [Intel-gfx] [PATCH] drm/i915: Unalias obj->phys_handle and obj->userptr From: Joonas Lahtinen To: Chris Wilson , intel-gfx@lists.freedesktop.org Cc: stable@vger.kernel.org Date: Mon, 03 Oct 2016 10:18:03 +0300 In-Reply-To: <20160930173139.24397-1-chris@chris-wilson.co.uk> References: <20160930173139.24397-1-chris@chris-wilson.co.uk> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: stable-owner@vger.kernel.org List-ID: On pe, 2016-09-30 at 18:31 +0100, Chris Wilson wrote: > We use obj->phys_handle to choose the pread/pwrite path, but as > obj->phys_handle is a union with obj->userptr, we then mistakenly use > the phys_handle path for userptr objects within pread/pwrite. > > Testcase: igt/gem_userptr_blits/forbidden-operations > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=97519 > Signed-off-by: Chris Wilson > Cc: stable@vger.kernel.org Reviewed-by: Joonas Lahtinen Regards, Joonas -- Joonas Lahtinen Open Source Technology Center Intel Corporation