From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:50167 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753070AbcJEITb (ORCPT ); Wed, 5 Oct 2016 04:19:31 -0400 Subject: Patch "i40iw: Do not set self-referencing pointer to NULL after kfree" has been added to the 4.7-stable tree To: mustafa.ismail@intel.com, dledford@redhat.com, gregkh@linuxfoundation.org, sassmann@redhat.com, shiraz.saleem@intel.com Cc: , From: Date: Wed, 05 Oct 2016 10:18:16 +0200 Message-ID: <147565549624144@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org List-ID: This is a note to let you know that I've just added the patch titled i40iw: Do not set self-referencing pointer to NULL after kfree to the 4.7-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: i40iw-do-not-set-self-referencing-pointer-to-null-after-kfree.patch and it can be found in the queue-4.7 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let know about it. >>From 7eaf8313b1cfe93417a22bdc3f7380cac2a3dc6d Mon Sep 17 00:00:00 2001 From: Mustafa Ismail Date: Mon, 22 Aug 2016 19:01:47 -0500 Subject: i40iw: Do not set self-referencing pointer to NULL after kfree From: Mustafa Ismail commit 7eaf8313b1cfe93417a22bdc3f7380cac2a3dc6d upstream. In i40iw_free_virt_mem(), do not set mem->va to NULL after freeing it as mem->va is a self-referencing pointer to mem. Fixes: 4e9042e647ff ("i40iw: add hw and utils files") Reported-by: Stefan Assmann Signed-off-by: Mustafa Ismail Signed-off-by: Shiraz Saleem Signed-off-by: Doug Ledford Signed-off-by: Greg Kroah-Hartman --- drivers/infiniband/hw/i40iw/i40iw_utils.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) --- a/drivers/infiniband/hw/i40iw/i40iw_utils.c +++ b/drivers/infiniband/hw/i40iw/i40iw_utils.c @@ -673,8 +673,11 @@ enum i40iw_status_code i40iw_free_virt_m { if (!mem) return I40IW_ERR_PARAM; + /* + * mem->va points to the parent of mem, so both mem and mem->va + * can not be touched once mem->va is freed + */ kfree(mem->va); - mem->va = NULL; return 0; } Patches currently in stable-queue which might be from mustafa.ismail@intel.com are queue-4.7/i40iw-update-hw_iwarp_state.patch queue-4.7/i40iw-add-missing-check-for-interface-already-open.patch queue-4.7/i40iw-fix-double-free-of-allocated_buffer.patch queue-4.7/i40iw-receive-notification-events-correctly.patch queue-4.7/i40iw-change-mem_resources-pointer-to-a-u8.patch queue-4.7/i40iw-protect-req_resource_num-update.patch queue-4.7/i40iw-add-missing-null-check-for-mpa-private-data.patch queue-4.7/i40iw-avoid-writing-to-freed-memory.patch queue-4.7/i40iw-do-not-set-self-referencing-pointer-to-null-after-kfree.patch