* Patch "[media] v4l: rcar-fcp: Don't force users to check for disabled FCP support" has been added to the 4.8-stable tree
@ 2016-10-18 14:43 gregkh
0 siblings, 0 replies; only message in thread
From: gregkh @ 2016-10-18 14:43 UTC (permalink / raw)
To: laurent.pinchart+renesas, geert+renesas, gregkh, mchehab,
sergei.shtylyov
Cc: stable, stable-commits
This is a note to let you know that I've just added the patch titled
[media] v4l: rcar-fcp: Don't force users to check for disabled FCP support
to the 4.8-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
v4l-rcar-fcp-don-t-force-users-to-check-for-disabled-fcp-support.patch
and it can be found in the queue-4.8 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@vger.kernel.org> know about it.
>From fd44aa9a254b18176ec3792a18e7de6977030ca8 Mon Sep 17 00:00:00 2001
From: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Date: Wed, 17 Aug 2016 09:57:37 -0300
Subject: [media] v4l: rcar-fcp: Don't force users to check for disabled FCP support
From: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
commit fd44aa9a254b18176ec3792a18e7de6977030ca8 upstream.
The rcar_fcp_enable() function immediately returns successfully when the
FCP device pointer is NULL to avoid forcing the users to check the FCP
device manually before every call. However, the stub version of the
function used when the FCP driver is disabled returns -ENOSYS
unconditionally, resulting in a different API contract for the two
versions of the function.
As a user that requires FCP support will fail at probe time when calling
rcar_fcp_get() if the FCP driver is disabled, the stub version of the
rcar_fcp_enable() function will only be called with a NULL FCP device.
We can thus return 0 unconditionally to align the behaviour with the
normal version of the function.
Reported-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
include/media/rcar-fcp.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/include/media/rcar-fcp.h
+++ b/include/media/rcar-fcp.h
@@ -29,7 +29,7 @@ static inline struct rcar_fcp_device *rc
static inline void rcar_fcp_put(struct rcar_fcp_device *fcp) { }
static inline int rcar_fcp_enable(struct rcar_fcp_device *fcp)
{
- return -ENOSYS;
+ return 0;
}
static inline void rcar_fcp_disable(struct rcar_fcp_device *fcp) { }
#endif
Patches currently in stable-queue which might be from laurent.pinchart+renesas@ideasonboard.com are
queue-4.8/v4l-rcar-fcp-don-t-force-users-to-check-for-disabled-fcp-support.patch
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2016-10-18 14:43 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-18 14:43 Patch "[media] v4l: rcar-fcp: Don't force users to check for disabled FCP support" has been added to the 4.8-stable tree gregkh
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).