From: Russell Currey <ruscur@russell.cc>
To: Greg KH <greg@kroah.com>
Cc: stable@vger.kernel.org, Michael Ellerman <mpe@ellerman.id.au>
Subject: Re: [4.4 PATCH] powerpc/eeh: Null check uses of eeh_pe_bus_get
Date: Thu, 27 Oct 2016 16:22:15 +1100 [thread overview]
Message-ID: <1477545735.27094.1.camel@russell.cc> (raw)
In-Reply-To: <20161027051209.GA30694@kroah.com>
On Thu, 2016-10-27 at 07:12 +0200, Greg KH wrote:
> On Thu, Oct 27, 2016 at 10:19:45AM +1100, Russell Currey wrote:
> > eeh_pe_bus_get() can return NULL if a PCI bus isn't found for a given PE.
> > Some callers don't check this, and can cause a null pointer dereference
> > under certain circumstances.
> >
> > Fix this by checking NULL everywhere eeh_pe_bus_get() is called.
> >
> > Fixes: 8a6b1bc70dbb ("powerpc/eeh: EEH core to handle special event")
> > Cc: stable@vger.kernel.org # v3.11+
> > Signed-off-by: Russell Currey <ruscur@russell.cc>
> > Reviewed-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
> > Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
> > ---
> > this specific patch for 4.4 only
>
> Why? I can't take a "specific patch only" unless you have a whole lot
> of good description about why, and how, and what, and everything else...
>
> Why can't I just take a patch that is already in Linus's tree? Whenever
> we don't do that, it always (yes really), ends up being wrong.
>
> thanks,
>
> greg k-h
Sorry, that was worded poorly. This patch is commit
04fec21c06e35b169a83e75a84a015ab4606bf5e upstream.
What I _meant_ is that this patch specifically applies to 4.4.
next prev parent reply other threads:[~2016-10-27 5:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-26 23:19 [4.4 PATCH] powerpc/eeh: Null check uses of eeh_pe_bus_get Russell Currey
2016-10-27 5:12 ` Greg KH
2016-10-27 5:22 ` Russell Currey [this message]
2016-10-27 5:33 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1477545735.27094.1.camel@russell.cc \
--to=ruscur@russell.cc \
--cc=greg@kroah.com \
--cc=mpe@ellerman.id.au \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).