stable.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Patch "coresight: Remove erroneous dma_free_coherent in tmc_probe" has been added to the 4.8-stable tree
@ 2016-10-28 17:33 gregkh
  0 siblings, 0 replies; only message in thread
From: gregkh @ 2016-10-28 17:33 UTC (permalink / raw)
  To: suzuki.poulose, gregkh, mathieu.poirier; +Cc: stable, stable-commits


This is a note to let you know that I've just added the patch titled

    coresight: Remove erroneous dma_free_coherent in tmc_probe

to the 4.8-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     coresight-remove-erroneous-dma_free_coherent-in-tmc_probe.patch
and it can be found in the queue-4.8 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@vger.kernel.org> know about it.


>From 481e46fe7a88557b66330cbb047b25cc13eff4b9 Mon Sep 17 00:00:00 2001
From: Suzuki K Poulose <suzuki.poulose@arm.com>
Date: Thu, 25 Aug 2016 15:18:54 -0600
Subject: coresight: Remove erroneous dma_free_coherent in tmc_probe

From: Suzuki K Poulose <suzuki.poulose@arm.com>

commit 481e46fe7a88557b66330cbb047b25cc13eff4b9 upstream.

commit de5461970b3e9e194 ("coresight: tmc: allocating memory when needed")
removed the static allocation of buffer for the trace data in ETR mode in
tmc_probe. However it failed to remove the "devm_free_coherent" in
tmc_probe when the probe fails due to other reasons. This patch gets
rid of the incorrect dma_free_coherent() call.

Fixes: commit de5461970b3e9e194 ("coresight: tmc: allocating memory when needed")
Cc: Mathieu Poirier <mathieu.poirier@linaro.org>
Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

---
 drivers/hwtracing/coresight/coresight-tmc.c |    3 ---
 1 file changed, 3 deletions(-)

--- a/drivers/hwtracing/coresight/coresight-tmc.c
+++ b/drivers/hwtracing/coresight/coresight-tmc.c
@@ -388,9 +388,6 @@ static int tmc_probe(struct amba_device
 err_misc_register:
 	coresight_unregister(drvdata->csdev);
 err_devm_kzalloc:
-	if (drvdata->config_type == TMC_CONFIG_TYPE_ETR)
-		dma_free_coherent(dev, drvdata->size,
-				drvdata->vaddr, drvdata->paddr);
 	return ret;
 }
 


Patches currently in stable-queue which might be from suzuki.poulose@arm.com are

queue-4.8/coresight-remove-erroneous-dma_free_coherent-in-tmc_probe.patch

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2016-10-28 17:33 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-28 17:33 Patch "coresight: Remove erroneous dma_free_coherent in tmc_probe" has been added to the 4.8-stable tree gregkh

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).