From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:51958 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751062AbcKIKIh (ORCPT ); Wed, 9 Nov 2016 05:08:37 -0500 Subject: Patch "ARM: 8584/1: floppy: avoid gcc-6 warning" has been added to the 4.4-stable tree To: arnd@arndb.de, gregkh@linuxfoundation.org, rmk+kernel@arm.linux.org.uk Cc: , From: Date: Wed, 09 Nov 2016 11:08:45 +0100 Message-ID: <147868612516661@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org List-ID: This is a note to let you know that I've just added the patch titled ARM: 8584/1: floppy: avoid gcc-6 warning to the 4.4-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: arm-8584-1-floppy-avoid-gcc-6-warning.patch and it can be found in the queue-4.4 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let know about it. >>From dd665be0e243873343a28e18f9f345927b658daf Mon Sep 17 00:00:00 2001 From: Arnd Bergmann Date: Fri, 1 Jul 2016 18:02:22 +0100 Subject: ARM: 8584/1: floppy: avoid gcc-6 warning From: Arnd Bergmann commit dd665be0e243873343a28e18f9f345927b658daf upstream. gcc-6.0 warns about comparisons between two identical expressions, which is what we get in the floppy driver when writing to the FD_DOR register: drivers/block/floppy.c: In function 'set_dor': drivers/block/floppy.c:810:44: error: self-comparison always evaluates to true [-Werror=tautological-compare] fd_outb(newdor, FD_DOR); It would be nice to use a static inline function instead of the macro, to avoid the warning, but we cannot do that because the FD_DOR definition is incomplete at this point. Adding a cast to (u32) is a harmless way to shut up the warning, just not very nice. Signed-off-by: Arnd Bergmann Signed-off-by: Russell King Signed-off-by: Greg Kroah-Hartman --- arch/arm/include/asm/floppy.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/arch/arm/include/asm/floppy.h +++ b/arch/arm/include/asm/floppy.h @@ -17,7 +17,7 @@ #define fd_outb(val,port) \ do { \ - if ((port) == FD_DOR) \ + if ((port) == (u32)FD_DOR) \ fd_setdor((val)); \ else \ outb((val),(port)); \ Patches currently in stable-queue which might be from arnd@arndb.de are queue-4.4/drm-exynos-fix-error-handling-in-exynos_drm_subdrv_open.patch queue-4.4/arm-8584-1-floppy-avoid-gcc-6-warning.patch queue-4.4/powerpc-ptrace-fix-out-of-bounds-array-access-warning.patch queue-4.4/cgroup-avoid-false-positive-gcc-6-warning.patch queue-4.4/smc91x-avoid-self-comparison-warning.patch