Patch "xprtrdma: use complete() instead complete_all()" has been added to the 4.8-stable tree

Patch "xprtrdma: use complete() instead complete_all()" has been added to the 4.8-stable tree

[gregkh]

This is a note to let you know that I've just added the patch titled

    xprtrdma: use complete() instead complete_all()

to the 4.8-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     xprtrdma-use-complete-instead-complete_all.patch
and it can be found in the queue-4.8 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@vger.kernel.org> know about it.


>From 5690a22d8612e1788b48b4ea53c59868589cd2db Mon Sep 17 00:00:00 2001
From: Daniel Wagner <daniel.wagner@bmw-carit.de>
Date: Fri, 23 Sep 2016 10:41:57 +0200
Subject: xprtrdma: use complete() instead complete_all()

From: Daniel Wagner <daniel.wagner@bmw-carit.de>

commit 5690a22d8612e1788b48b4ea53c59868589cd2db upstream.

There is only one waiter for the completion, therefore there
is no need to use complete_all(). Let's make that clear by
using complete() instead of complete_all().

The usage pattern of the completion is:

waiter context                          waker context

frwr_op_unmap_sync()
  reinit_completion()
  ib_post_send()
  wait_for_completion()

					frwr_wc_localinv_wake()
					  complete()

Signed-off-by: Daniel Wagner <daniel.wagner@bmw-carit.de>
Cc: Anna Schumaker <Anna.Schumaker@Netapp.com>
Cc: Trond Myklebust <trond.myklebust@primarydata.com>
Cc: Chuck Lever <chuck.lever@oracle.com>
Cc: linux-nfs@vger.kernel.org
Cc: netdev@vger.kernel.org
Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

---
 net/sunrpc/xprtrdma/frwr_ops.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/net/sunrpc/xprtrdma/frwr_ops.c
+++ b/net/sunrpc/xprtrdma/frwr_ops.c
@@ -329,7 +329,7 @@ frwr_wc_localinv_wake(struct ib_cq *cq,
 	frmr = container_of(cqe, struct rpcrdma_frmr, fr_cqe);
 	if (wc->status != IB_WC_SUCCESS)
 		__frwr_sendcompletion_flush(wc, frmr, "localinv");
-	complete_all(&frmr->fr_linv_done);
+	complete(&frmr->fr_linv_done);
 }
 
 /* Post a REG_MR Work Request to register a memory region


Patches currently in stable-queue which might be from daniel.wagner@bmw-carit.de are

queue-4.8/xprtrdma-use-complete-instead-complete_all.patch

Re: Patch "xprtrdma: use complete() instead complete_all()" has been added to the 4.8-stable tree

[Daniel Wagner]

Hi Greg,

On 11/17/2016 08:15 AM, gregkh@linuxfoundation.org wrote:
> From 5690a22d8612e1788b48b4ea53c59868589cd2db Mon Sep 17 00:00:00 2001
> From: Daniel Wagner <daniel.wagner@bmw-carit.de>
> Date: Fri, 23 Sep 2016 10:41:57 +0200
> Subject: xprtrdma: use complete() instead complete_all()
>
> From: Daniel Wagner <daniel.wagner@bmw-carit.de>
>
> commit 5690a22d8612e1788b48b4ea53c59868589cd2db upstream.
>
> There is only one waiter for the completion, therefore there
> is no need to use complete_all(). Let's make that clear by
> using complete() instead of complete_all().
>
> The usage pattern of the completion is:
>
> waiter context                          waker context
>
> frwr_op_unmap_sync()
>   reinit_completion()
>   ib_post_send()
>   wait_for_completion()
>
> 					frwr_wc_localinv_wake()
> 					  complete()

I don't think this needs to got into stable. The original code isn't 
broken. This patch is a cleanup unless I miss something :)

cheers,
daniel

Re: Patch "xprtrdma: use complete() instead complete_all()" has been added to the 4.8-stable tree

[Greg KH]

On Thu, Nov 17, 2016 at 11:55:31AM +0100, Daniel Wagner wrote:
> Hi Greg,
> 
> On 11/17/2016 08:15 AM, gregkh@linuxfoundation.org wrote:
> > From 5690a22d8612e1788b48b4ea53c59868589cd2db Mon Sep 17 00:00:00 2001
> > From: Daniel Wagner <daniel.wagner@bmw-carit.de>
> > Date: Fri, 23 Sep 2016 10:41:57 +0200
> > Subject: xprtrdma: use complete() instead complete_all()
> > 
> > From: Daniel Wagner <daniel.wagner@bmw-carit.de>
> > 
> > commit 5690a22d8612e1788b48b4ea53c59868589cd2db upstream.
> > 
> > There is only one waiter for the completion, therefore there
> > is no need to use complete_all(). Let's make that clear by
> > using complete() instead of complete_all().
> > 
> > The usage pattern of the completion is:
> > 
> > waiter context                          waker context
> > 
> > frwr_op_unmap_sync()
> >   reinit_completion()
> >   ib_post_send()
> >   wait_for_completion()
> > 
> > 					frwr_wc_localinv_wake()
> > 					  complete()
> 
> I don't think this needs to got into stable. The original code isn't broken.
> This patch is a cleanup unless I miss something :)

It is needed for the patch after this one in the series.

thanks,

greg k-h

Re: Patch "xprtrdma: use complete() instead complete_all()" has been added to the 4.8-stable tree

[Daniel Wagner]

>> I don't think this needs to got into stable. The original code isn't broken.
>> This patch is a cleanup unless I miss something :)
>
> It is needed for the patch after this one in the series.

Ah, thanks for the clarification. I haven't checked the whole series 
obviously. Sorry about that.

cheers,
daniel