stable.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Patch "IPoIB: Avoid reading an uninitialized member variable" has been added to the 4.8-stable tree
@ 2017-01-06 15:00 gregkh
  0 siblings, 0 replies; only message in thread
From: gregkh @ 2017-01-06 15:00 UTC (permalink / raw)
  To: bart.vanassche, dledford, erezsh, gregkh, leonro; +Cc: stable, stable-commits


This is a note to let you know that I've just added the patch titled

    IPoIB: Avoid reading an uninitialized member variable

to the 4.8-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     ipoib-avoid-reading-an-uninitialized-member-variable.patch
and it can be found in the queue-4.8 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@vger.kernel.org> know about it.


>From 11b642b84e8c43e8597de031678d15c08dd057bc Mon Sep 17 00:00:00 2001
From: Bart Van Assche <bart.vanassche@sandisk.com>
Date: Mon, 21 Nov 2016 10:21:41 -0800
Subject: IPoIB: Avoid reading an uninitialized member variable

From: Bart Van Assche <bart.vanassche@sandisk.com>

commit 11b642b84e8c43e8597de031678d15c08dd057bc upstream.

This patch avoids that Coverity reports the following:

    Using uninitialized value port_attr.state when calling printk

Fixes: commit 94232d9ce817 ("IPoIB: Start multicast join process only on active ports")
Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>
Cc: Erez Shitrit <erezsh@mellanox.com>
Reviewed-by: Leon Romanovsky <leonro@mellanox.com>
Signed-off-by: Doug Ledford <dledford@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

---
 drivers/infiniband/ulp/ipoib/ipoib_multicast.c |    7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

--- a/drivers/infiniband/ulp/ipoib/ipoib_multicast.c
+++ b/drivers/infiniband/ulp/ipoib/ipoib_multicast.c
@@ -575,8 +575,11 @@ void ipoib_mcast_join_task(struct work_s
 	if (!test_bit(IPOIB_FLAG_OPER_UP, &priv->flags))
 		return;
 
-	if (ib_query_port(priv->ca, priv->port, &port_attr) ||
-	    port_attr.state != IB_PORT_ACTIVE) {
+	if (ib_query_port(priv->ca, priv->port, &port_attr)) {
+		ipoib_dbg(priv, "ib_query_port() failed\n");
+		return;
+	}
+	if (port_attr.state != IB_PORT_ACTIVE) {
 		ipoib_dbg(priv, "port state is not ACTIVE (state = %d) suspending join task\n",
 			  port_attr.state);
 		return;


Patches currently in stable-queue which might be from bart.vanassche@sandisk.com are

queue-4.8/ib-mad-fix-an-array-index-check.patch
queue-4.8/ipoib-avoid-reading-an-uninitialized-member-variable.patch
queue-4.8/ib-rxe-fix-a-memory-leak-in-rxe_qp_cleanup.patch
queue-4.8/ib-multicast-check-ib_find_pkey-return-value.patch
queue-4.8/ib-cma-fix-a-race-condition-in-iboe_addr_get_sgid.patch
queue-4.8/iscsi-target-return-error-if-unable-to-add-network-portal.patch

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2017-01-06 15:00 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-01-06 15:00 Patch "IPoIB: Avoid reading an uninitialized member variable" has been added to the 4.8-stable tree gregkh

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).